Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 2013473003: [Devtools] Esc closes searchview if focused and open (Closed)

Created:
4 years, 6 months ago by allada
Modified:
4 years, 6 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Esc closes searchview if focused and open If ESC key is pressed while search input box is focused and open it will now always close the search input box and stop propagation. BUG=613232 R=lushnikov Committed: https://crrev.com/2c9c1f684d0376f3be57284da16ab5c70ba0ff9b Cr-Commit-Position: refs/heads/master@{#396363}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/SearchableView.js View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
allada
PTL
4 years, 6 months ago (2016-05-24 18:45:31 UTC) #1
lushnikov
https://codereview.chromium.org/2013473003/diff/1/third_party/WebKit/Source/devtools/front_end/ui/SearchableView.js File third_party/WebKit/Source/devtools/front_end/ui/SearchableView.js (right): https://codereview.chromium.org/2013473003/diff/1/third_party/WebKit/Source/devtools/front_end/ui/SearchableView.js#newcode420 third_party/WebKit/Source/devtools/front_end/ui/SearchableView.js:420: if (isEscKey(event)) { How does this work in other ...
4 years, 6 months ago (2016-05-24 22:44:13 UTC) #2
allada
PTL
4 years, 6 months ago (2016-05-25 22:45:54 UTC) #3
lushnikov
lgtm Please, make sure sources/elements panel searches do not break with this change (focus is ...
4 years, 6 months ago (2016-05-26 00:07:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013473003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013473003/20001
4 years, 6 months ago (2016-05-26 21:25:43 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-05-27 02:43:49 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 02:45:26 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2c9c1f684d0376f3be57284da16ab5c70ba0ff9b
Cr-Commit-Position: refs/heads/master@{#396363}

Powered by Google App Engine
This is Rietveld 408576698