Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2013403003:
Add logging in WidevineCdmComponentInstaller to help investigate a bug. (Closed)
DescriptionAdd logging in WidevineCdmComponentInstaller to help investigate a bug.
These logs will be removed after the investigation is finished.
BUG=614745
Committed: https://crrev.com/324623c7cf1ccb0a674a31fe15b3bf996f8f3f3a
Cr-Commit-Position: refs/heads/master@{#396570}
Patch Set 1 #Patch Set 2 : use LOG(WARNING) #Messages
Total messages: 19 (9 generated)
Description was changed from ========== Add logging in WidevineCdmComponentInstaller to help investigate a bug. BUG=614745 ========== to ========== Add logging in WidevineCdmComponentInstaller to help investigate a bug. These logs will be removed after the investigation is finished. BUG=614745 ==========
The CQ bit was checked by xhwang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013403003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013403003/1
xhwang@chromium.org changed reviewers: + waffles@chromium.org
I suspect that there's some delay on the blocking pool so when we start to run the test the CDM is not registered as a plugin yet. This CL is to add logs to check whether this is true or not. Since I need logs in release build (so far we can only repro this failure on a release windows clang 64 bot, see BUG), so I am using LOG(INFO). This actually isn't allowed by presubmit rules :( https://code.google.com/p/chromium/codesearch#chromium/src/PRESUBMIT.py&l=1178 I can change this to LOG(WARNING) if you like, or I can see whether I can just dcommit this CL. Let me know what you would prefer. Also, if there's any other interesting place that you think we can add more logs please let me know. PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by xhwang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013403003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013403003/20001
On 2016/05/27 20:18:50, commit-bot: I haz the power wrote: > Dry run: Try jobs failed on following builders: > chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) I updated the CL to use LOG(WARNING) to make PRESUBMIT happier. I'll be OOO for now. If it looks good to you please help CQ it. Or I can check where we are later today.
lgtm - will presubmit complain about a VLOG(0)? I think that should be enabled by default and might be an easier way out. Otherwise, dcommit or WARNING is fine with me, since this is so temporary.
The CQ bit was unchecked by xhwang@chromium.org
The CQ bit was checked by xhwang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013403003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013403003/20001
On 2016/05/27 20:25:30, commit-bot: I haz the power wrote: > CQ is trying da patch. Follow status at > https://chromium-cq-status.appspot.com/patch-status/2013403003/20001 > View timeline at > https://chromium-cq-status.appspot.com/patch-timeline/2013403003/20001 It seems even VLOG(0) requires --vmodule or --v=0...
Message was sent while issue was closed.
Description was changed from ========== Add logging in WidevineCdmComponentInstaller to help investigate a bug. These logs will be removed after the investigation is finished. BUG=614745 ========== to ========== Add logging in WidevineCdmComponentInstaller to help investigate a bug. These logs will be removed after the investigation is finished. BUG=614745 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add logging in WidevineCdmComponentInstaller to help investigate a bug. These logs will be removed after the investigation is finished. BUG=614745 ========== to ========== Add logging in WidevineCdmComponentInstaller to help investigate a bug. These logs will be removed after the investigation is finished. BUG=614745 Committed: https://crrev.com/324623c7cf1ccb0a674a31fe15b3bf996f8f3f3a Cr-Commit-Position: refs/heads/master@{#396570} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/324623c7cf1ccb0a674a31fe15b3bf996f8f3f3a Cr-Commit-Position: refs/heads/master@{#396570} |
