Fix wrong endianness of wasm header in WasmModuleWriter on big-endian platforms

Fix wrong endianness of wasm header in WasmModuleWriter on big-endian platforms

BUG=mjsunit/wasm/asm-wasm-f*,mjsunit/wasm/asm-wasm-i*

Committed: https://crrev.com/50c65fc147fa35984a72f8834b2852cdc53bfde4
Cr-Commit-Position: refs/heads/master@{#36548}

[ivica.bogosavljevic, 2016-05-27 10:21:20]

Description was changed from

==========
Fix wrong endianness of wasm header in WasmModuleWriter on big-endian platforms

BUG=
==========

to

==========
Fix wrong endianness of wasm header in WasmModuleWriter on big-endian platforms

BUG=mjsunit/wasm/asm-wasm-f*,mjsunit/wasm/asm-wasm-i*
==========

[ivica.bogosavljevic, 2016-05-27 10:22:27]

ivica.bogosavljevic@imgtec.com changed reviewers:
+ akos.palfi@imgtec.com, gergely.kis@imgtec.com, ilija.pavlovic@imgtec.com,
marija.antic@imgtec.com, miran.karic@imgtec.com, titzer@chromium.org

[ivica.bogosavljevic, 2016-05-27 10:25:20]

PTAL

[titzer, 2016-05-27 10:47:27]

https://codereview.chromium.org/2013393002/diff/1/src/wasm/encoder.cc
File src/wasm/encoder.cc (right):

https://codereview.chromium.org/2013393002/diff/1/src/wasm/encoder.cc#newcode302
src/wasm/encoder.cc:302:
buffer.write_u32(word32_to_little_endianness(&kWasmMagic));
What about instead making the write_u32 function always write little endian, and
forgoing the byte swap routines, similar to how the decoder always reads little
endian?

[ivica.bogosavljevic, 2016-05-27 12:23:24]

Done

https://codereview.chromium.org/2013393002/diff/1/src/wasm/encoder.cc
File src/wasm/encoder.cc (right):

https://codereview.chromium.org/2013393002/diff/1/src/wasm/encoder.cc#newcode302
src/wasm/encoder.cc:302:
buffer.write_u32(word32_to_little_endianness(&kWasmMagic));
On 2016/05/27 10:47:27, titzer wrote:
> What about instead making the write_u32 function always write little endian,
and
> forgoing the byte swap routines, similar to how the decoder always reads
little
> endian?

Say no more!

[titzer, 2016-05-27 12:33:55]

lgtm

[ivica.bogosavljevic, 2016-05-27 13:08:25]

The CQ bit was checked by ivica.bogosavljevic@imgtec.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-27 13:08:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2013393002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2013393002/20001

[commit-bot: I haz the power, 2016-05-27 13:32:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-27 13:32:20]

Dry run: This issue passed the CQ dry run.

[ivica.bogosavljevic, 2016-05-27 13:35:46]

The CQ bit was checked by ivica.bogosavljevic@imgtec.com

[commit-bot: I haz the power, 2016-05-27 13:35:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2013393002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2013393002/20001

[commit-bot: I haz the power, 2016-05-27 14:07:36]

Description was changed from

==========
Fix wrong endianness of wasm header in WasmModuleWriter on big-endian platforms

BUG=mjsunit/wasm/asm-wasm-f*,mjsunit/wasm/asm-wasm-i*
==========

to

==========
Fix wrong endianness of wasm header in WasmModuleWriter on big-endian platforms

BUG=mjsunit/wasm/asm-wasm-f*,mjsunit/wasm/asm-wasm-i*
==========

[commit-bot: I haz the power, 2016-05-27 14:07:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-27 14:09:10]

Description was changed from

==========
Fix wrong endianness of wasm header in WasmModuleWriter on big-endian platforms

BUG=mjsunit/wasm/asm-wasm-f*,mjsunit/wasm/asm-wasm-i*
==========

to

==========
Fix wrong endianness of wasm header in WasmModuleWriter on big-endian platforms

BUG=mjsunit/wasm/asm-wasm-f*,mjsunit/wasm/asm-wasm-i*

Committed: https://crrev.com/50c65fc147fa35984a72f8834b2852cdc53bfde4
Cr-Commit-Position: refs/heads/master@{#36548}
==========

[commit-bot: I haz the power, 2016-05-27 14:09:12]

Patchset 2 (id:??) landed as
https://crrev.com/50c65fc147fa35984a72f8834b2852cdc53bfde4
Cr-Commit-Position: refs/heads/master@{#36548}