Remove an unnecessary (empty) scope, streamline the function parsing code.

Remove an unnecessary (empty) scope, streamline the function parsing code.

The scope containing function expressions is always empty.

R=hausner@google.com

Committed: https://github.com/dart-lang/sdk/commit/c0bfda8a08225c1a4565fd77bda311a1110a112f

[Kevin Millikin (Google), 2016-05-27 14:07:35]

kmillikin@google.com changed reviewers:
+ hausner@google.com

[Kevin Millikin (Google), 2016-05-27 14:07:36]

https://codereview.chromium.org/2013233003/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (left):

https://codereview.chromium.org/2013233003/diff/1/runtime/vm/parser.cc#oldcod...
runtime/vm/parser.cc:7600: const String* variable_name = NULL;
If is_literal, variable_name is always NULL.  If !is_literal, variable_name is
always identical to function_name.

[hausner, 2016-05-27 15:55:00]

LGTM. This is probably some cruft left from the days when function literals
could have names.

[Kevin Millikin (Google), 2016-11-24 08:06:00]

Matthias, sorry for the delay.  I've rebased this change, could you to take
another quick look before I commit it?

[hausner, 2016-11-24 18:14:13]

Still LGTM.

Happy Thanksgiving

[Kevin Millikin (Google), 2016-11-25 09:24:22]

Description was changed from

==========
Remove an unnecessary (empty) scope, streamline the function parsing code.

The scope containing function expressions is always empty.
==========

to

==========
Remove an unnecessary (empty) scope, streamline the function parsing code.

The scope containing function expressions is always empty.

R=hausner@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c0bfda8a08225c1a4565fd77bda311a1110a112f
==========

[Kevin Millikin (Google), 2016-11-25 09:24:23]

Committed patchset #2 (id:20001) manually as
c0bfda8a08225c1a4565fd77bda311a1110a112f (presubmit successful).