Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2013233002: [tools/perf] Disable page_cycler_v2.typical_25 benchmark (Closed)

Created:
4 years, 7 months ago by nednguyen
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tools/perf] Disable page_cycler_v2.typical_25 benchmark TBR=kouhei@chromium.org BUG=615178 Committed: https://crrev.com/c84885e83ecac137b93ed2b6c8b7323d8e91ffe1 Cr-Commit-Position: refs/heads/master@{#396337}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tools/perf/benchmarks/page_cycler_v2.py View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013233002/1
4 years, 7 months ago (2016-05-26 22:18:23 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 7 months ago (2016-05-26 22:18:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013233002/1
4 years, 7 months ago (2016-05-26 22:20:18 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-27 01:00:03 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c84885e83ecac137b93ed2b6c8b7323d8e91ffe1 Cr-Commit-Position: refs/heads/master@{#396337}
4 years, 6 months ago (2016-05-27 01:04:23 UTC) #15
nednguyen
4 years, 6 months ago (2016-05-27 18:55:11 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2017123004/ by nednguyen@google.com.

The reason for reverting is: Stack trace of crash should be enabled now.
Reenable the benchmark to see what causes the failure..

Powered by Google App Engine
This is Rietveld 408576698