Debugger: fix crash in DebugEvaluate

Debugger: fix crash in DebugEvaluate

If scripts is paused in class constructor before super() call then any attempt to evaluate something like this.* on top frame will produce crash.

BUG=chromium:614019
R=yangguo@chromium.org

Committed: https://crrev.com/54245bd6b28dc0f1b50bf196e9453bbe948612df
Cr-Commit-Position: refs/heads/master@{#36625}

[kozy, 2016-05-26 23:51:37]

Yang, please take a look!

It isn't the best fix here because it materializes this as undefined before
super call and produces "Cannot read property of undefined" error.
It can be better if we can produce reference error for "this.*". WDYT?

[Yang, 2016-05-30 09:31:02]

On 2016/05/26 23:51:37, kozyatinskiy wrote:
> Yang, please take a look!
> 
> It isn't the best fix here because it materializes this as undefined before
> super call and produces "Cannot read property of undefined" error.
> It can be better if we can produce reference error for "this.*". WDYT?

LGTM. Thanks!

I think this is fix is fine. For arrow functions where the receiver is not
available in the outer context, we materialize undefined as well.

[kozy, 2016-05-31 15:01:52]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2016-05-31 15:01:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2013223003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2013223003/1

[commit-bot: I haz the power, 2016-05-31 15:19:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-31 15:19:48]

Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)

[kozy, 2016-05-31 21:39:21]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-05-31 21:39:22]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2013223003/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-05-31 21:39:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2013223003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2013223003/20001

[commit-bot: I haz the power, 2016-05-31 22:05:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-31 22:05:38]

Description was changed from

==========
Debugger: fix crash in DebugEvaluate

If scripts is paused in class constructor before super() call then any attempt
to evaluate something like this.* on top frame will produce crash.

BUG=chromium:614019
R=yangguo@chromium.org
==========

to

==========
Debugger: fix crash in DebugEvaluate

If scripts is paused in class constructor before super() call then any attempt
to evaluate something like this.* on top frame will produce crash.

BUG=chromium:614019
R=yangguo@chromium.org

Committed: https://crrev.com/54245bd6b28dc0f1b50bf196e9453bbe948612df
Cr-Commit-Position: refs/heads/master@{#36625}
==========

[commit-bot: I haz the power, 2016-05-31 22:05:39]

Patchset 2 (id:??) landed as
https://crrev.com/54245bd6b28dc0f1b50bf196e9453bbe948612df
Cr-Commit-Position: refs/heads/master@{#36625}