Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Unified Diff: tools/perf/benchmarks/system_health.py

Issue 2013223002: Add WebView startup time benchmark (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/system_health.py
diff --git a/tools/perf/benchmarks/system_health.py b/tools/perf/benchmarks/system_health.py
index 598ff82909401a4a9cc4b2a624cb84567c069a48..4324302a8ed8493a7deb997f3046df38f2745d99 100644
--- a/tools/perf/benchmarks/system_health.py
+++ b/tools/perf/benchmarks/system_health.py
@@ -38,6 +38,7 @@ class SystemHealthTop25(_SystemHealthBenchmark):
def Name(cls):
return 'system_health.top25'
+
@benchmark.Disabled('android') # crbug.com/601953
@benchmark.Disabled('all') # crbug.com/613050
class SystemHealthKeyMobileSites(_SystemHealthBenchmark):
@@ -73,6 +74,27 @@ class _MemorySystemHealthBenchmark(perf_benchmark.PerfBenchmark):
def Name(cls):
return 'system_health.memory_%s' % cls.page_set.PLATFORM
+@benchmark.Enabled('android')
+class WebviewStartupSystemHealthBenchmark(_SystemHealthBenchmark):
+ """Chrome Webview Startup Time System Health Benchmark.
charliea (OOO until 10-5) 2016/06/08 20:57:58 I don't think this first line is useful. I'd prefe
alexandermont 2016/06/08 21:09:15 Done
+
+ Benchmark that measures the amount of time that WebView takes
+ to start up and then to load a blank page.
+ """
+ page_set = page_sets.BlankPageSet
charliea (OOO until 10-5) 2016/06/08 20:57:58 nit: can you add a blank line between this line an
alexandermont 2016/06/08 21:09:15 Done
+ def CreateTimelineBasedMeasurementOptions(self):
+ options = timeline_based_measurement.Options(
charliea (OOO until 10-5) 2016/06/08 20:57:58 nit: this can be deleted (it's the default)
alexandermont 2016/06/08 21:09:15 Done
+ tracing_category_filter.TracingCategoryFilter())
+ options.SetTimelineBasedMetric('webviewStartupMetric')
+ options.config.enable_atrace_trace = True
+ options.config.enable_chrome_trace = False
charliea (OOO until 10-5) 2016/06/08 20:57:58 nit: this can be deleted (it's the default)
alexandermont 2016/06/08 21:09:15 Done
+ options.config.atrace_config.app_name = 'org.chromium.webview_shell'
+ return options
+
+ @classmethod
+ def Name(cls):
+ return 'system_health.webview_startup'
+
# https://github.com/catapult-project/catapult/issues/2340
@benchmark.Disabled('all')
class DesktopMemorySystemHealth(_MemorySystemHealthBenchmark):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698