Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Side by Side Diff: tools/perf/benchmarks/system_health.py

Issue 2013223002: Add WebView startup time benchmark (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from core import perf_benchmark 5 from core import perf_benchmark
6 from telemetry import benchmark 6 from telemetry import benchmark
7 from telemetry.timeline import tracing_category_filter 7 from telemetry.timeline import tracing_category_filter
8 from telemetry.web_perf import timeline_based_measurement 8 from telemetry.web_perf import timeline_based_measurement
9 import page_sets 9 import page_sets
10 10
(...skipping 20 matching lines...) Expand all
31 31
32 32
33 @benchmark.Disabled('all') # crbug.com/613050 33 @benchmark.Disabled('all') # crbug.com/613050
34 class SystemHealthTop25(_SystemHealthBenchmark): 34 class SystemHealthTop25(_SystemHealthBenchmark):
35 page_set = page_sets.Top25PageSet 35 page_set = page_sets.Top25PageSet
36 36
37 @classmethod 37 @classmethod
38 def Name(cls): 38 def Name(cls):
39 return 'system_health.top25' 39 return 'system_health.top25'
40 40
41
41 @benchmark.Disabled('android') # crbug.com/601953 42 @benchmark.Disabled('android') # crbug.com/601953
42 @benchmark.Disabled('all') # crbug.com/613050 43 @benchmark.Disabled('all') # crbug.com/613050
44
43 class SystemHealthKeyMobileSites(_SystemHealthBenchmark): 45 class SystemHealthKeyMobileSites(_SystemHealthBenchmark):
44 page_set = page_sets.KeyMobileSitesPageSet 46 page_set = page_sets.KeyMobileSitesPageSet
45 47
46 @classmethod 48 @classmethod
47 def Name(cls): 49 def Name(cls):
48 return 'system_health.key_mobile_sites' 50 return 'system_health.key_mobile_sites'
49 51
50 52
51 class _MemorySystemHealthBenchmark(perf_benchmark.PerfBenchmark): 53 class _MemorySystemHealthBenchmark(perf_benchmark.PerfBenchmark):
52 """Chrome Memory System Health Benchmark. 54 """Chrome Memory System Health Benchmark.
(...skipping 13 matching lines...) Expand all
66 tracing_category_filter.TracingCategoryFilter( 68 tracing_category_filter.TracingCategoryFilter(
67 '-*,disabled-by-default-memory-infra')) 69 '-*,disabled-by-default-memory-infra'))
68 options.config.enable_android_graphics_memtrack = True 70 options.config.enable_android_graphics_memtrack = True
69 options.SetTimelineBasedMetric('memoryMetric') 71 options.SetTimelineBasedMetric('memoryMetric')
70 return options 72 return options
71 73
72 @classmethod 74 @classmethod
73 def Name(cls): 75 def Name(cls):
74 return 'system_health.memory_%s' % cls.page_set.PLATFORM 76 return 'system_health.memory_%s' % cls.page_set.PLATFORM
75 77
78
79 @benchmark.Enabled('android')
80 class WebviewStartupSystemHealthBenchmark(_SystemHealthBenchmark):
81 """Chrome Webview Startup Time system health Benchmark. """
charliea (OOO until 10-5) 2016/06/06 19:52:53 nit: system health should be capitalized (like abo
charliea (OOO until 10-5) 2016/06/06 19:52:53 nit: I think that we want to add more context to t
charliea (OOO until 10-5) 2016/06/06 19:52:53 nit: delete trailing space
alexandermont 2016/06/06 23:30:16 Done
82 page_set = page_sets.BlankPageSet
83 def CreateTimelineBasedMeasurementOptions(self):
84 options = timeline_based_measurement.Options(
85 tracing_category_filter.TracingCategoryFilter())
86 options.SetTimelineBasedMetric('webviewStartupMetric')
87 options.config.enable_atrace_trace = True
88 options.config.enable_chrome_trace = False
89 options.config.atrace_app_name = 'org.chromium.webview_shell'
90 return options
91
92 @classmethod
93 def Name(cls):
94 return 'system_health.webview_startup'
95
76 # https://github.com/catapult-project/catapult/issues/2340 96 # https://github.com/catapult-project/catapult/issues/2340
77 @benchmark.Disabled('all') 97 @benchmark.Disabled('all')
78 class DesktopMemorySystemHealth(_MemorySystemHealthBenchmark): 98 class DesktopMemorySystemHealth(_MemorySystemHealthBenchmark):
79 """Desktop Chrome Memory System Health Benchmark.""" 99 """Desktop Chrome Memory System Health Benchmark."""
80 page_set = page_sets.DesktopMemorySystemHealthStorySet 100 page_set = page_sets.DesktopMemorySystemHealthStorySet
81 101
82 @classmethod 102 @classmethod
83 def ShouldDisable(cls, possible_browser): 103 def ShouldDisable(cls, possible_browser):
84 return possible_browser.platform.GetDeviceTypeName() != 'Desktop' 104 return possible_browser.platform.GetDeviceTypeName() != 'Desktop'
85 105
86 # https://github.com/catapult-project/catapult/issues/2340 106 # https://github.com/catapult-project/catapult/issues/2340
87 @benchmark.Disabled('all') 107 @benchmark.Disabled('all')
88 class MobileMemorySystemHealth(_MemorySystemHealthBenchmark): 108 class MobileMemorySystemHealth(_MemorySystemHealthBenchmark):
89 """Mobile Chrome Memory System Health Benchmark.""" 109 """Mobile Chrome Memory System Health Benchmark."""
90 page_set = page_sets.MobileMemorySystemHealthStorySet 110 page_set = page_sets.MobileMemorySystemHealthStorySet
91 111
92 @classmethod 112 @classmethod
93 def ShouldDisable(cls, possible_browser): 113 def ShouldDisable(cls, possible_browser):
94 # http://crbug.com/612144 (reference on Nexus 5X). 114 # http://crbug.com/612144 (reference on Nexus 5X).
95 return possible_browser.platform.GetDeviceTypeName() == 'Desktop' or ( 115 return possible_browser.platform.GetDeviceTypeName() == 'Desktop' or (
96 possible_browser.browser_type == 'reference' and 116 possible_browser.browser_type == 'reference' and
97 possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X') 117 possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X')
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698