Add WebView startup time benchmark

tools/perf/benchmarks/system_health.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from core import perf_benchmark
 from telemetry import benchmark
 from telemetry.timeline import tracing_category_filter
 from telemetry.web_perf import timeline_based_measurement
 import page_sets
 
@@ skipping 12 matching lines @@
     options.SetTimelineBasedMetric('SystemHealthMetrics')
     return options
 
   @classmethod
   def ShouldDisable(cls, browser):
     # http://crbug.com/600463
     galaxy_s5_type_name = 'SM-G900H'
     return browser.platform.GetDeviceTypeName() == galaxy_s5_type_name
 
 
-@benchmark.Disabled('all')  # crbug.com/613050
 class SystemHealthTop25(_SystemHealthBenchmark):
   page_set = page_sets.Top25PageSet
 
   @classmethod
   def Name(cls):
     return 'system_health.top25'
 
-@benchmark.Disabled('android')  # crbug.com/601953
-@benchmark.Disabled('all')  # crbug.com/613050
+# crbug.com/601953
+@benchmark.Disabled('android')

[charliea (OOO until 10-5), 2016/05/27 23:27:26]

Huh? Is this a diffbase problem? Seems like we definitely don't want to alter
this in the CL.

[alexandermont, 2016/05/31 17:21:44]

I think this is correct. I didn't intend to change this. Now changed back.

 class SystemHealthKeyMobileSites(_SystemHealthBenchmark):
   page_set = page_sets.KeyMobileSitesPageSet
 
   @classmethod
   def Name(cls):
     return 'system_health.key_mobile_sites'
 
 
 class _MemorySystemHealthBenchmark(perf_benchmark.PerfBenchmark):
   """Chrome Memory System Health Benchmark.
@@ skipping 13 matching lines @@
         tracing_category_filter.TracingCategoryFilter(
             '-*,disabled-by-default-memory-infra'))
     options.config.enable_android_graphics_memtrack = True
     options.SetTimelineBasedMetric('memoryMetric')
     return options
 
   @classmethod
   def Name(cls):
     return 'system_health.memory_%s' % cls.page_set.PLATFORM
 
-# https://github.com/catapult-project/catapult/issues/2340
-@benchmark.Disabled('all')
+class WebviewStartupSystemHealthBenchmark(_SystemHealthBenchmark):

[charliea (OOO until 10-5), 2016/05/27 23:27:26]

nednguyen@chromium.org, do we want @benchmark.Disabled('all') on this for now?

I'd assume that the most we want is @benchmark.Enabled('android')

I'd definitely assume that we want some annotation on this, though, because
otherwise it might try to run on non-Android devices, right?

+  """Chrome Webview Startup System Health Benchmark.

[charliea (OOO until 10-5), 2016/05/27 23:27:26]

nit: might want to making this "Chrome WebView Startup Time..."

[alexandermont, 2016/05/31 17:21:44]

Done

+  """

[charliea (OOO until 10-5), 2016/05/27 23:27:26]

nit: can we put the ending """ on the same line as the rest?

[alexandermont, 2016/05/31 17:21:44]

Done

+  page_set = page_sets.BlankPageSet
+  def CreateTimelineBasedMeasurementOptions(self):
+    options = timeline_based_measurement.Options(
+        tracing_category_filter.TracingCategoryFilter(
+            '-*,disabled-by-default-memory-infra'))

[charliea (OOO until 10-5), 2016/05/27 23:27:26]

Not sure exactly how this tracing category filter works, but I doubt that we
want memory-infra enabled here?

Also, any idea what -* is needed for?

[alexandermont, 2016/05/31 17:21:44]

Removed

[perezju, 2016/06/07 08:39:17]

The -* is used on memory infra benchmarks to disable (chrome) tracing on
everything except memory infra. Also not sure if system_health is the best
location for this benchmark. Maybe it should live on its own new file?

+primiano any thoughts?

+    options.SetTimelineBasedMetric('WebviewStartupMetric')

[charliea (OOO until 10-5), 2016/05/27 23:27:26]

note: based on suggestion in other CL, this should probably become
'webviewStartupMetric'

[alexandermont, 2016/05/31 17:21:44]

Done

+    options.config.enable_atrace_trace = True
+    options.config.enable_chrome_trace = False
+    options.config.app_name = 'org.chromium.webview_shell'
+    return options
+
+  @classmethod
+  def Name(cls):

[charliea (OOO until 10-5), 2016/05/27 23:27:26]

not sure about the python style here, but same note as other CL: don't you
sometimes name arguments like this 'unused' or something?

I've also seen: 

del cls

not sure when each is used

[alexandermont, 2016/05/31 17:21:45]

I can't find anything specific about this in the Google Python style guide. But
in general, my understanding is that since this is a @classmethod, the first
argument is always "cls" (the class object), just like the first argument in
ordinary methods is "self".

+    return 'system_health.webview_startup'
+
+
 class DesktopMemorySystemHealth(_MemorySystemHealthBenchmark):
   """Desktop Chrome Memory System Health Benchmark."""
   page_set = page_sets.DesktopMemorySystemHealthStorySet
 
   @classmethod
   def ShouldDisable(cls, possible_browser):
     return possible_browser.platform.GetDeviceTypeName() != 'Desktop'
 
-# https://github.com/catapult-project/catapult/issues/2340
-@benchmark.Disabled('all')
+

[charliea (OOO until 10-5), 2016/05/27 23:27:26]

Also doubt that we want to alter this

[alexandermont, 2016/05/31 17:21:44]

Changed back

 class MobileMemorySystemHealth(_MemorySystemHealthBenchmark):
   """Mobile Chrome Memory System Health Benchmark."""
   page_set = page_sets.MobileMemorySystemHealthStorySet
 
   @classmethod
   def ShouldDisable(cls, possible_browser):
     # http://crbug.com/612144 (reference on Nexus 5X).
     return possible_browser.platform.GetDeviceTypeName() == 'Desktop' or (
         possible_browser.browser_type == 'reference' and
         possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X')