content_shell: Update absolute path rewriting logic again.

content_shell: Update absolute path rewriting logic again.

With this CL, we rewrite absolute-looking paths only in
web-platform-tests and csswg-test. RewriteAbsolutePathInWPT() doesn't affect
non-W3C tests at all.

BUG=614778
Committed: https://crrev.com/2edc979d193cd4a03ac02b67ccdc7b3a979e6232
Cr-Commit-Position: refs/heads/master@{#396396}

[tkent, 2016-05-27 01:27:11]

Patchset #1 (id:1) has been deleted

[tkent, 2016-05-27 01:27:46]

Description was changed from

==========
content_shell: Updat absolute path rewriting logic again.

With this CL, we rewrite abosolute-looking paths only in
web-platform-tests. RewriteAbsolutePathInWPT() doesn't affect non-WPT
tests at all.

BUG=614778
==========

to

==========
content_shell: Update absolute path rewriting logic again.

With this CL, we rewrite absolute-looking paths only in
web-platform-tests and csswg-test. RewriteAbsolutePathInWPT() doesn't affect
non-W3C tests at all.

BUG=614778
==========

[tkent, 2016-05-27 03:27:09]

tkent@chromium.org changed reviewers:
+ kinuko@chromium.org

[tkent, 2016-05-27 03:27:09]

Kinuko-san, would you approve this again?

[kinuko, 2016-05-27 03:35:57]

lgtm

https://codereview.chromium.org/2013203003/diff/20001/components/test_runner/...
File components/test_runner/web_test_delegate.h (right):

https://codereview.chromium.org/2013203003/diff/20001/components/test_runner/...
components/test_runner/web_test_delegate.h:106: // LayoutTests directory, or
rewrite URLs genrated from absolute
nit: genrated -> generated

https://codereview.chromium.org/2013203003/diff/20001/content/shell/renderer/...
File content/shell/renderer/layout_test/blink_test_runner.cc (right):

https://codereview.chromium.org/2013203003/diff/20001/content/shell/renderer/...
content/shell/renderer/layout_test/blink_test_runner.cc:556: return
RewriteLayoutTestsURL(result, false).string().utf8();
nit: can we add a comment like /* is_wpt_mode */ after 'false' ?

[tkent, 2016-05-27 03:43:03]

https://codereview.chromium.org/2013203003/diff/20001/components/test_runner/...
File components/test_runner/web_test_delegate.h (right):

https://codereview.chromium.org/2013203003/diff/20001/components/test_runner/...
components/test_runner/web_test_delegate.h:106: // LayoutTests directory, or
rewrite URLs genrated from absolute
On 2016/05/27 at 03:35:57, kinuko wrote:
> nit: genrated -> generated

Done.

https://codereview.chromium.org/2013203003/diff/20001/content/shell/renderer/...
File content/shell/renderer/layout_test/blink_test_runner.cc (right):

https://codereview.chromium.org/2013203003/diff/20001/content/shell/renderer/...
content/shell/renderer/layout_test/blink_test_runner.cc:556: return
RewriteLayoutTestsURL(result, false).string().utf8();
On 2016/05/27 at 03:35:57, kinuko wrote:
> nit: can we add a comment like /* is_wpt_mode */ after 'false' ?

Done.

[tkent, 2016-05-27 03:58:13]

The CQ bit was checked by tkent@chromium.org

[tkent, 2016-05-27 03:58:14]

The patchset sent to the CQ was uploaded after l-g-t-m from kinuko@chromium.org
Link to the patchset: https://codereview.chromium.org/2013203003/#ps40001
(title: "update comments")

[commit-bot: I haz the power, 2016-05-27 03:58:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2013203003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2013203003/40001

[commit-bot: I haz the power, 2016-05-27 04:58:37]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-05-27 05:00:27]

Description was changed from

==========
content_shell: Update absolute path rewriting logic again.

With this CL, we rewrite absolute-looking paths only in
web-platform-tests and csswg-test. RewriteAbsolutePathInWPT() doesn't affect
non-W3C tests at all.

BUG=614778
==========

to

==========
content_shell: Update absolute path rewriting logic again.

With this CL, we rewrite absolute-looking paths only in
web-platform-tests and csswg-test. RewriteAbsolutePathInWPT() doesn't affect
non-W3C tests at all.

BUG=614778

Committed: https://crrev.com/2edc979d193cd4a03ac02b67ccdc7b3a979e6232
Cr-Commit-Position: refs/heads/master@{#396396}
==========

[commit-bot: I haz the power, 2016-05-27 05:00:28]

Patchset 2 (id:??) landed as
https://crrev.com/2edc979d193cd4a03ac02b67ccdc7b3a979e6232
Cr-Commit-Position: refs/heads/master@{#396396}