Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: pkg/analyzer/test/src/summary/resynthesize_test.dart

Issue 2013193003: Remove skipBrokenAstInference flag (it is no longer needed). (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/test/src/summary/resynthesize_ast_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/src/summary/resynthesize_test.dart
diff --git a/pkg/analyzer/test/src/summary/resynthesize_test.dart b/pkg/analyzer/test/src/summary/resynthesize_test.dart
index 3f3f8ef792c5ff50d26d73bfac0bdfb37368ab71..13cc75e8d94da7a8e9aab279f1a8ffa8d0c5388d 100644
--- a/pkg/analyzer/test/src/summary/resynthesize_test.dart
+++ b/pkg/analyzer/test/src/summary/resynthesize_test.dart
@@ -51,16 +51,6 @@ abstract class AbstractResynthesizeTest extends AbstractSingleUnitTest {
bool get checkPropagatedTypes => true;
- /**
- * Derived classes can override this getter to return `true` in order to
- * cause certain checks to be skipped if they are known to fail with
- * AST-based type inference.
- *
- * TODO(paulberry): remove this flag once AST-based type inference is fully
- * working.
- */
- bool get skipBrokenAstInference => false;
-
void addLibrary(String uri) {
otherLibrarySources.add(context.sourceFactory.forUri(uri));
}
@@ -1111,10 +1101,8 @@ abstract class AbstractResynthesizeTest extends AbstractSingleUnitTest {
VariableElementImpl resynthesizedActual =
getActualElement(resynthesized, desc);
VariableElementImpl originalActual = getActualElement(original, desc);
- if (!skipBrokenAstInference) {
- compareFunctionElements(resynthesizedActual.initializer,
- originalActual.initializer, '$desc initializer');
- }
+ compareFunctionElements(resynthesizedActual.initializer,
+ originalActual.initializer, '$desc initializer');
if (originalActual is ConstVariableElement) {
Element oEnclosing = original.enclosingElement;
if (oEnclosing is ClassElement && oEnclosing.isEnum) {
« no previous file with comments | « pkg/analyzer/test/src/summary/resynthesize_ast_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698