Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2013163003: Change to disable a warning for GCC compilation (Closed)

Created:
4 years, 6 months ago by Wei Li
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com, llozano
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Change to disable a warning for GCC compilation The warning was only shown and asked not to be treated as an error. However, some recent flag change of chromeos toolchain has some interference with the warning. To avoid future problem, disable the warning for GCC. BUG=chromium:615424 Committed: https://pdfium.googlesource.com/pdfium/+/d23df55b95716a4b6021ab600b99fd31954c8052

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M xfa.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Wei Li
pls review, thanks
4 years, 6 months ago (2016-05-27 20:01:25 UTC) #3
Lei Zhang
+llozano
4 years, 6 months ago (2016-05-27 20:06:15 UTC) #4
Lei Zhang
lgtm
4 years, 6 months ago (2016-05-27 20:06:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013163003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013163003/1
4 years, 6 months ago (2016-05-27 20:09:35 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 20:21:59 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/d23df55b95716a4b6021ab600b99fd31954c...

Powered by Google App Engine
This is Rietveld 408576698