Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issue 2013123002: Guard against unresolved code (issue 26545) (Closed)

Created:
4 years, 7 months ago by Brian Wilkerson
Modified:
4 years, 6 months ago
Reviewers:
jwren
CC:
reviews_dartlang.org, danrubel
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Handle is case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart/optype.dart View 1 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Brian Wilkerson
Is it reasonable for the static type to be null at this point? If so, ...
4 years, 7 months ago (2016-05-26 20:09:17 UTC) #2
jwren
On 2016/05/26 20:09:17, Brian Wilkerson wrote: > Is it reasonable for the static type to ...
4 years, 6 months ago (2016-05-26 22:26:22 UTC) #3
Brian Wilkerson
Done. But you didn't answer the question: is this a reasonable fix?
4 years, 6 months ago (2016-05-27 16:13:42 UTC) #4
jwren
On 2016/05/27 16:13:42, Brian Wilkerson wrote: > Done. But you didn't answer the question: is ...
4 years, 6 months ago (2016-05-27 16:57:24 UTC) #5
jwren
On 2016/05/27 16:57:24, jwren wrote: > On 2016/05/27 16:13:42, Brian Wilkerson wrote: > > Done. ...
4 years, 6 months ago (2016-05-27 18:02:41 UTC) #6
Brian Wilkerson
4 years, 6 months ago (2016-05-27 19:14:09 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
6b04e74aa05768c8d11fd302baf8a486db31d53d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698