Separate BaseInstrumentationTestRunner from BaseChromiumITR

Separate BaseInstrumentationTestRunner from BaseChromiumITR

BUG=615104
Committed: https://crrev.com/60c6ae2a354c9f99ebd787e577cf7972da3e985c
Cr-Commit-Position: refs/heads/master@{#396906}

[Yoland Yan(Google), 2016-05-26 17:51:06]

Description was changed from

==========
Separate BaseInstrumentationTestRunner from BaseChromiumITR

BUG=
==========

to

==========
Separate BaseInstrumentationTestRunner from BaseChromiumITR

BUG=615104
==========

[Yoland Yan(Google), 2016-05-26 17:51:30]

yolandyan@google.com changed reviewers:
+ jbudorick@chromium.org, mikecase@chromium.org, mkwst@chromium.org,
sgurun@chromium.org, wez@chromium.org

[Yoland Yan(Google), 2016-05-26 18:06:37]

yolandyan@google.com changed reviewers:
+ haibinlu@chromium.org

[jbudorick, 2016-05-26 18:06:44]

jbudorick@chromium.org changed reviewers:
- haibinlu@chromium.org

[jbudorick, 2016-05-26 18:06:44]

https://codereview.chromium.org/2013113002/diff/1/base/test/android/javatests...
File
base/test/android/javatests/src/org/chromium/base/test/BaseChromiumInstrumentationTestRunner.java
(right):

https://codereview.chromium.org/2013113002/diff/1/base/test/android/javatests...
base/test/android/javatests/src/org/chromium/base/test/BaseChromiumInstrumentationTestRunner.java:14:
* An Instrumentation test runner for applications that are based on {@code
BaseChromiumApplication}
nit: you may need to specify BaseChromiumApplication's package here.

https://codereview.chromium.org/2013113002/diff/1/base/test/android/javatests...
File
base/test/android/javatests/src/org/chromium/base/test/BaseInstrumentationTestRunner.java
(right):

https://codereview.chromium.org/2013113002/diff/1/base/test/android/javatests...
base/test/android/javatests/src/org/chromium/base/test/BaseInstrumentationTestRunner.java:27:
* {@code BaseChromiumApplication}, one should use {@code
BaseChromiumInstrumentationTestRunner}
nit: same re BaseChromiumApplication's package

https://codereview.chromium.org/2013113002/diff/1/base/test/android/javatests...
base/test/android/javatests/src/org/chromium/base/test/BaseInstrumentationTestRunner.java:30:
@Override
Remove onCreate entirely.

[Yoland Yan(Google), 2016-05-26 18:13:50]

https://codereview.chromium.org/2013113002/diff/1/base/test/android/javatests...
File
base/test/android/javatests/src/org/chromium/base/test/BaseChromiumInstrumentationTestRunner.java
(right):

https://codereview.chromium.org/2013113002/diff/1/base/test/android/javatests...
base/test/android/javatests/src/org/chromium/base/test/BaseChromiumInstrumentationTestRunner.java:14:
* An Instrumentation test runner for applications that are based on {@code
BaseChromiumApplication}
On 2016/05/26 18:06:44, jbudorick wrote:
> nit: you may need to specify BaseChromiumApplication's package here.

Done.

https://codereview.chromium.org/2013113002/diff/1/base/test/android/javatests...
File
base/test/android/javatests/src/org/chromium/base/test/BaseInstrumentationTestRunner.java
(right):

https://codereview.chromium.org/2013113002/diff/1/base/test/android/javatests...
base/test/android/javatests/src/org/chromium/base/test/BaseInstrumentationTestRunner.java:27:
* {@code BaseChromiumApplication}, one should use {@code
BaseChromiumInstrumentationTestRunner}
On 2016/05/26 18:06:44, jbudorick wrote:
> nit: same re BaseChromiumApplication's package

Done.

https://codereview.chromium.org/2013113002/diff/1/base/test/android/javatests...
base/test/android/javatests/src/org/chromium/base/test/BaseInstrumentationTestRunner.java:30:
@Override
On 2016/05/26 18:06:44, jbudorick wrote:
> Remove onCreate entirely.

Done.

[Yoland Yan(Google), 2016-05-26 18:15:12]

yolandyan@google.com changed reviewers:
+ peter@chromium.org

[Wez, 2016-05-26 19:49:10]

blimp/ rubber-stamp LGTM

[jbudorick, 2016-05-26 21:28:06]

lgtm

[Yoland Yan(Google), 2016-05-26 21:34:52]

yolandyan@google.com changed reviewers:
+ thakis@chromium.org

[sgurun-gerrit only, 2016-05-27 22:01:24]

https://codereview.chromium.org/2013113002/diff/20001/base/test/android/javat...
File
base/test/android/javatests/src/org/chromium/base/test/BaseChromiumInstrumentationTestRunner.java
(right):

https://codereview.chromium.org/2013113002/diff/20001/base/test/android/javat...
base/test/android/javatests/src/org/chromium/base/test/BaseChromiumInstrumentationTestRunner.java:17:
public class BaseChromiumInstrumentationTestRunner extends
BaseInstrumentationTestRunner {
name not compatible with the class extending, ChromeInstrumentationTestRunner.
Rename to BaseChromeInstrumentationTestRunner

[jbudorick, 2016-05-27 22:06:34]

https://codereview.chromium.org/2013113002/diff/20001/base/test/android/javat...
File
base/test/android/javatests/src/org/chromium/base/test/BaseChromiumInstrumentationTestRunner.java
(right):

https://codereview.chromium.org/2013113002/diff/20001/base/test/android/javat...
base/test/android/javatests/src/org/chromium/base/test/BaseChromiumInstrumentationTestRunner.java:17:
public class BaseChromiumInstrumentationTestRunner extends
BaseInstrumentationTestRunner {
On 2016/05/27 22:01:24, sgurun wrote:
> name not compatible with the class extending, ChromeInstrumentationTestRunner.
> Rename to BaseChromeInstrumentationTestRunner

I disagree. ChromeITR is so named because it's in //chrome. BaseChromiumITR is
so named because it's specific to applications extending from
BaseChromiumApplication.

[sgurun-gerrit only, 2016-05-28 01:42:02]

On 2016/05/27 22:06:34, jbudorick wrote:
>
https://codereview.chromium.org/2013113002/diff/20001/base/test/android/javat...
> File
>
base/test/android/javatests/src/org/chromium/base/test/BaseChromiumInstrumentationTestRunner.java
> (right):
> 
>
https://codereview.chromium.org/2013113002/diff/20001/base/test/android/javat...
>
base/test/android/javatests/src/org/chromium/base/test/BaseChromiumInstrumentationTestRunner.java:17:
> public class BaseChromiumInstrumentationTestRunner extends
> BaseInstrumentationTestRunner {
> On 2016/05/27 22:01:24, sgurun wrote:
> > name not compatible with the class extending,
ChromeInstrumentationTestRunner.
> > Rename to BaseChromeInstrumentationTestRunner
> 
> I disagree. ChromeITR is so named because it's in //chrome. BaseChromiumITR is
> so named because it's specific to applications extending from
> BaseChromiumApplication.

ok then. lgtm

[Mike West, 2016-05-30 11:01:19]

content/shell LGTM.

[Yoland Yan(Google), 2016-05-31 18:18:48]

yolandyan@google.com changed reviewers:
+ thestig@chromium.org

[Yoland Yan(Google), 2016-05-31 18:20:45]

yolandyan@google.com changed reviewers:
+ danakj@google.com

[Yoland Yan(Google), 2016-05-31 18:21:09]

yolandyan@google.com changed reviewers:
+ danakj@chromium.org
- danakj@google.com

[danakj, 2016-05-31 18:25:24]

BUILD LGTM

[Lei Zhang, 2016-05-31 18:26:19]

On 2016/05/31 18:18:49, Yoland Yan(Google) wrote:

If you are adding new (non-psychic) reviewers, please tell them what you want
them to review.

[Yoland Yan(Google), 2016-05-31 18:27:26]

On 2016/05/31 18:26:19, Lei Zhang wrote:
> On 2016/05/31 18:18:49, Yoland Yan(Google) wrote:
> 
> If you are adding new (non-psychic) reviewers, please tell them what you want
> them to review.

Will do in the future

[Yoland Yan(Google), 2016-05-31 18:27:28]

On 2016/05/31 18:26:19, Lei Zhang wrote:
> On 2016/05/31 18:18:49, Yoland Yan(Google) wrote:
> 
> If you are adding new (non-psychic) reviewers, please tell them what you want
> them to review.

Will do in the future

[Yoland Yan(Google), 2016-05-31 18:27:34]

The CQ bit was checked by yolandyan@google.com

[commit-bot: I haz the power, 2016-05-31 18:28:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2013113002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2013113002/20001

[commit-bot: I haz the power, 2016-05-31 20:05:04]

Description was changed from

==========
Separate BaseInstrumentationTestRunner from BaseChromiumITR

BUG=615104
==========

to

==========
Separate BaseInstrumentationTestRunner from BaseChromiumITR

BUG=615104
==========

[commit-bot: I haz the power, 2016-05-31 20:05:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-31 20:44:55]

Description was changed from

==========
Separate BaseInstrumentationTestRunner from BaseChromiumITR

BUG=615104
==========

to

==========
Separate BaseInstrumentationTestRunner from BaseChromiumITR

BUG=615104

Committed: https://crrev.com/60c6ae2a354c9f99ebd787e577cf7972da3e985c
Cr-Commit-Position: refs/heads/master@{#396906}
==========

[commit-bot: I haz the power, 2016-05-31 20:44:57]

Patchset 2 (id:??) landed as
https://crrev.com/60c6ae2a354c9f99ebd787e577cf7972da3e985c
Cr-Commit-Position: refs/heads/master@{#396906}