Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2013073002: Fix cr_cronet.py APK install when custom build directory is used (Closed)

Created:
4 years, 7 months ago by mgersh
Modified:
4 years, 6 months ago
Reviewers:
mef
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix cr_cronet.py APK install when custom build directory is used BUG=600857 Committed: https://crrev.com/0af00b485a970dd36e8276547c79c02a146accd5 Cr-Commit-Position: refs/heads/master@{#399203}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M components/cronet/tools/cr_cronet.py View 2 chunks +10 lines, -10 lines 2 comments Download

Messages

Total messages: 9 (3 generated)
mgersh
PTAL
4 years, 7 months ago (2016-05-26 15:10:32 UTC) #2
mef
lgtm https://codereview.chromium.org/2013073002/diff/1/components/cronet/tools/cr_cronet.py File components/cronet/tools/cr_cronet.py (right): https://codereview.chromium.org/2013073002/diff/1/components/cronet/tools/cr_cronet.py#newcode29 components/cronet/tools/cr_cronet.py:29: run(cmd.format(build_dir, release_arg, 'ChromiumNetTestSupport.apk')) is this properly aligned?
4 years, 6 months ago (2016-06-09 21:16:46 UTC) #3
mgersh
https://codereview.chromium.org/2013073002/diff/1/components/cronet/tools/cr_cronet.py File components/cronet/tools/cr_cronet.py (right): https://codereview.chromium.org/2013073002/diff/1/components/cronet/tools/cr_cronet.py#newcode29 components/cronet/tools/cr_cronet.py:29: run(cmd.format(build_dir, release_arg, 'ChromiumNetTestSupport.apk')) On 2016/06/09 21:16:46, mef wrote: > ...
4 years, 6 months ago (2016-06-10 15:45:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013073002/1
4 years, 6 months ago (2016-06-10 15:45:38 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-10 16:27:09 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 16:28:46 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0af00b485a970dd36e8276547c79c02a146accd5
Cr-Commit-Position: refs/heads/master@{#399203}

Powered by Google App Engine
This is Rietveld 408576698