Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Unified Diff: components/autofill/core/browser/autofill_profile_unittest.cc

Issue 2013063002: Remove diacritics when normalizing autofill profile strings for comparison. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Simplify normalization loop and expand test cases. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_profile_unittest.cc
diff --git a/components/autofill/core/browser/autofill_profile_unittest.cc b/components/autofill/core/browser/autofill_profile_unittest.cc
index 7a6630f8b2b184744aeec2a46ce17fd226664cb7..dc82c01203fc580838e7870fed918bf864cff4ff 100644
--- a/components/autofill/core/browser/autofill_profile_unittest.cc
+++ b/components/autofill/core/browser/autofill_profile_unittest.cc
@@ -1153,6 +1153,10 @@ TEST(AutofillProfileTest, CanonicalizeProfileString) {
EXPECT_EQ(ASCIIToUTF16("1600 amphitheatre pkwy app 2"),
AutofillProfile::CanonicalizeProfileString(
ASCIIToUTF16("1600 amphitheatre pkwy \n App. 2")));
+
+ // Diacritics removed.
+ EXPECT_EQ(UTF8ToUTF16("まeoa정"),
+ AutofillProfile::CanonicalizeProfileString(UTF8ToUTF16("まéÖä정")));
}
TEST(AutofillProfileTest, SaveAdditionalInfo_Name_AddingNameFull) {
@@ -1196,7 +1200,8 @@ TEST(AutofillProfileTest, SaveAdditionalInfo_Name_KeepNameFull) {
// Tests the merging of two similar profiles results in the second profile's
// non-empty fields overwriting the initial profiles values.
-TEST(AutofillProfileTest, SaveAdditionalInfo_Name_DifferentCaseNoNameFull) {
+TEST(AutofillProfileTest,
+ SaveAdditionalInfo_Name_DifferentCaseAndDiacriticsNoNameFull) {
AutofillProfile a;
a.SetRawInfo(NAME_FIRST, base::ASCIIToUTF16("marion"));
@@ -1205,19 +1210,19 @@ TEST(AutofillProfileTest, SaveAdditionalInfo_Name_DifferentCaseNoNameFull) {
a.SetRawInfo(NAME_FULL, base::ASCIIToUTF16("marion mitchell morrison"));
AutofillProfile b = a;
- b.SetRawInfo(NAME_FIRST, base::ASCIIToUTF16("Marion"));
- b.SetRawInfo(NAME_MIDDLE, base::ASCIIToUTF16("Mitchell"));
- b.SetRawInfo(NAME_LAST, base::ASCIIToUTF16("Morrison"));
- b.SetRawInfo(NAME_FULL, base::ASCIIToUTF16(""));
+ b.SetRawInfo(NAME_FIRST, UTF8ToUTF16("Märion"));
+ b.SetRawInfo(NAME_MIDDLE, UTF8ToUTF16("Mitchéll"));
+ b.SetRawInfo(NAME_LAST,UTF8ToUTF16("Morrison"));
+ b.SetRawInfo(NAME_FULL, UTF8ToUTF16(""));
EXPECT_TRUE(a.SaveAdditionalInfo(b, "en-US"));
// The first, middle and last names should have their first letter in
- // uppercase.
- EXPECT_EQ(base::ASCIIToUTF16("Marion"), a.GetRawInfo(NAME_FIRST));
- EXPECT_EQ(base::ASCIIToUTF16("Mitchell"), a.GetRawInfo(NAME_MIDDLE));
- EXPECT_EQ(base::ASCIIToUTF16("Morrison"), a.GetRawInfo(NAME_LAST));
- EXPECT_EQ(base::ASCIIToUTF16("marion mitchell morrison"),
+ // uppercase and have acquired diacritics.
+ EXPECT_EQ(UTF8ToUTF16("Märion"), a.GetRawInfo(NAME_FIRST));
+ EXPECT_EQ(UTF8ToUTF16("Mitchéll"), a.GetRawInfo(NAME_MIDDLE));
+ EXPECT_EQ(UTF8ToUTF16("Morrison"), a.GetRawInfo(NAME_LAST));
+ EXPECT_EQ(UTF8ToUTF16("marion mitchell morrison"),
a.GetRawInfo(NAME_FULL));
}

Powered by Google App Engine
This is Rietveld 408576698