Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: components/autofill/core/browser/autofill_manager_unittest.cc

Issue 2013063002: Remove diacritics when normalizing autofill profile strings for comparison. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Expand unit-tests Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_manager_unittest.cc
diff --git a/components/autofill/core/browser/autofill_manager_unittest.cc b/components/autofill/core/browser/autofill_manager_unittest.cc
index c9fd67d0f7eebd0220dae7f83dce36308a7a06b7..941e1d8bd3b7370a449531e0a017ee76e4c7b6e6 100644
--- a/components/autofill/core/browser/autofill_manager_unittest.cc
+++ b/components/autofill/core/browser/autofill_manager_unittest.cc
@@ -3514,7 +3514,7 @@ TEST_F(AutofillManagerTest, DeterminePossibleFieldTypesForUpload) {
profiles.push_back(profile);
test::SetProfileInfo(&profile, "Charles", "", "Baudelaire",
"lesfleursdumal@gmail.com", "", "108 Rue Saint-Lazare",
- "Apt. 10", "Paris", "Ile de France", "75008", "FR",
+ "Apt. 10", "Paris", "Île de France", "75008", "FR",
"+33 2 49 19 70 70");
profile.set_guid("00000000-0000-0000-0000-000000000001");
profiles.push_back(profile);
@@ -3560,7 +3560,7 @@ TEST_F(AutofillManagerTest, DeterminePossibleFieldTypesForUpload) {
// Test an european profile.
{"Paris", ADDRESS_HOME_CITY},
- {"Ile de France", ADDRESS_HOME_STATE},
+ {"Ile de France", ADDRESS_HOME_STATE}, // Note: missing accent on Île.
Mathieu 2016/05/27 17:47:13 Could we expand the test cases to verify other thi
Roger McFarlane (Chromium) 2016/05/27 20:20:42 Done.
{"75008", ADDRESS_HOME_ZIP},
{"FR", ADDRESS_HOME_COUNTRY},
{"France", ADDRESS_HOME_COUNTRY},

Powered by Google App Engine
This is Rietveld 408576698