Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: src/hydrogen-bce.cc

Issue 201303007: Fix assert in BoundsCheckBbData. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 128
129 bool OffsetIsCovered(int32_t offset) const { 129 bool OffsetIsCovered(int32_t offset) const {
130 return offset >= LowerOffset() && offset <= UpperOffset(); 130 return offset >= LowerOffset() && offset <= UpperOffset();
131 } 131 }
132 132
133 bool HasSingleCheck() { return lower_check_ == upper_check_; } 133 bool HasSingleCheck() { return lower_check_ == upper_check_; }
134 134
135 void UpdateUpperOffsets(HBoundsCheck* check, int32_t offset) { 135 void UpdateUpperOffsets(HBoundsCheck* check, int32_t offset) {
136 BoundsCheckBbData* data = FatherInDominatorTree(); 136 BoundsCheckBbData* data = FatherInDominatorTree();
137 while (data != NULL && data->UpperCheck() == check) { 137 while (data != NULL && data->UpperCheck() == check) {
138 ASSERT(data->upper_offset_ <= offset); 138 ASSERT(data->upper_offset_ < offset);
139 data->upper_offset_ = offset; 139 data->upper_offset_ = offset;
140 data = data->FatherInDominatorTree(); 140 data = data->FatherInDominatorTree();
141 } 141 }
142 } 142 }
143 143
144 void UpdateLowerOffsets(HBoundsCheck* check, int32_t offset) { 144 void UpdateLowerOffsets(HBoundsCheck* check, int32_t offset) {
145 BoundsCheckBbData* data = FatherInDominatorTree(); 145 BoundsCheckBbData* data = FatherInDominatorTree();
146 while (data != NULL && data->LowerCheck() == check) { 146 while (data != NULL && data->LowerCheck() == check) {
147 ASSERT(data->lower_offset_ > offset); 147 ASSERT(data->lower_offset_ > offset);
148 data->lower_offset_ = offset; 148 data->lower_offset_ = offset;
(...skipping 276 matching lines...) Expand 10 before | Expand all | Expand 10 after
425 if (data->FatherInDominatorTree()) { 425 if (data->FatherInDominatorTree()) {
426 table_.Insert(data->Key(), data->FatherInDominatorTree(), zone()); 426 table_.Insert(data->Key(), data->FatherInDominatorTree(), zone());
427 } else { 427 } else {
428 table_.Delete(data->Key()); 428 table_.Delete(data->Key());
429 } 429 }
430 data = data->NextInBasicBlock(); 430 data = data->NextInBasicBlock();
431 } 431 }
432 } 432 }
433 433
434 } } // namespace v8::internal 434 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698