Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 201303006: Remove deprecated API for createAudioDevice. (Closed)

Created:
6 years, 9 months ago by KhNo
Modified:
6 years, 8 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove deprecated API for createAudioDevice. Blink is calling new API createAudioDevice(). It needs to remove. TODO(crogers): remove deprecated API as soon as WebKit calls new API. This patch is related with https://codereview.chromium.org/201723003/ BUG=353110 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260855

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -32 lines) Patch
M content/renderer/renderer_webkitplatformsupport_impl.h View 1 chunk +0 lines, -9 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
KhNo
Please review the patch. :)
6 years, 9 months ago (2014-03-17 12:34:39 UTC) #1
Raymond Toy
+dalecurtis, Dale, are you familiar with this code and if you are, have we completely ...
6 years, 9 months ago (2014-03-17 18:02:38 UTC) #2
DaleCurtis
Sorry, I don't know anything about this code.
6 years, 9 months ago (2014-03-17 18:09:40 UTC) #3
KhNo
On 2014/03/17 18:09:40, DaleCurtis wrote: > Sorry, I don't know anything about this code. Dale ...
6 years, 9 months ago (2014-03-17 23:44:53 UTC) #4
KhNo
On 2014/03/17 23:44:53, KhNo wrote: > On 2014/03/17 18:09:40, DaleCurtis wrote: > > Sorry, I ...
6 years, 9 months ago (2014-03-19 17:13:34 UTC) #5
DaleCurtis
lgtm
6 years, 9 months ago (2014-03-19 17:36:37 UTC) #6
KhNo
On 2014/03/19 17:36:37, DaleCurtis wrote: > lgtm Thank you :)
6 years, 9 months ago (2014-03-20 01:28:03 UTC) #7
KhNo
The CQ bit was checked by keonho07.kim@samsung.com
6 years, 9 months ago (2014-03-20 01:38:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keonho07.kim@samsung.com/201303006/1
6 years, 9 months ago (2014-03-20 01:39:40 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 02:12:47 UTC) #10
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=56350
6 years, 9 months ago (2014-03-20 02:12:47 UTC) #11
KhNo
James, Please review :)
6 years, 9 months ago (2014-03-20 02:25:07 UTC) #12
KhNo
On 2014/03/19 17:36:37, DaleCurtis wrote: > lgtm Dear Adam barth. This patch is related previous ...
6 years, 9 months ago (2014-03-24 05:28:31 UTC) #13
abarth-chromium
LGTM, but I don't think I'm an OWNER here
6 years, 9 months ago (2014-03-24 16:08:53 UTC) #14
KhNo
On 2014/03/24 16:08:53, abarth wrote: > LGTM, but I don't think I'm an OWNER here ...
6 years, 9 months ago (2014-03-25 07:01:23 UTC) #15
KhNo
On 2014/03/25 07:01:23, KhNo wrote: > On 2014/03/24 16:08:53, abarth wrote: > > LGTM, but ...
6 years, 9 months ago (2014-03-26 11:48:23 UTC) #16
KhNo
@jochen, Can I get OWNER's LGTM ? Actually jamer was out of office.
6 years, 8 months ago (2014-04-01 10:54:28 UTC) #17
jochen (gone - plz use gerrit)
lgtm
6 years, 8 months ago (2014-04-01 10:56:44 UTC) #18
KhNo
On 2014/04/01 10:56:44, jochen wrote: > lgtm thank you.
6 years, 8 months ago (2014-04-01 11:07:02 UTC) #19
KhNo
The CQ bit was checked by keonho07.kim@samsung.com
6 years, 8 months ago (2014-04-01 11:07:10 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keonho07.kim@samsung.com/201303006/1
6 years, 8 months ago (2014-04-01 11:07:13 UTC) #21
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 13:48:46 UTC) #22
Message was sent while issue was closed.
Change committed as 260855

Powered by Google App Engine
This is Rietveld 408576698