Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2012963002: Add and clean up docstrings in webkitpy/w3c. (Closed)

Created:
4 years, 7 months ago by qyearsley
Modified:
4 years, 6 months ago
Reviewers:
tkent, Dirk Pranke, jsbell, ojan
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add and clean up docstrings in webkitpy/w3c. Committed: https://crrev.com/64ad32cbe89ef061a7f92339bf18006fa1765028 Cr-Commit-Position: refs/heads/master@{#397052}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -59 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py View 1 2 7 chunks +23 lines, -9 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py View 1 2 5 chunks +8 lines, -5 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py View 1 2 5 chunks +46 lines, -40 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_parser.py View 1 3 chunks +11 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_parser_unittest.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
qyearsley
4 years, 7 months ago (2016-05-26 00:23:07 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012963002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2012963002/20001
4 years, 7 months ago (2016-05-26 01:00:04 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/228449)
4 years, 7 months ago (2016-05-26 03:41:52 UTC) #6
Dirk Pranke
lgtm
4 years, 6 months ago (2016-06-01 00:08:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012963002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2012963002/40001
4 years, 6 months ago (2016-06-01 03:12:42 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-01 04:17:29 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 04:19:00 UTC) #15
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/64ad32cbe89ef061a7f92339bf18006fa1765028
Cr-Commit-Position: refs/heads/master@{#397052}

Powered by Google App Engine
This is Rietveld 408576698