Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2012943003: add more SK_WARN_UNUSED_RESULT attributes to functions that ignore out-params if they fail (Closed)

Created:
4 years, 7 months ago by reed1
Modified:
4 years, 7 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

add more SK_WARN_UNUSED_RESULT attributes to functions that ignore out-params if they fail BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2012943003 TBR= Committed: https://skia.googlesource.com/skia/+/497290824f8d2eb6705fd2785e1851cecf9e2b03

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/core/SkCubicClipper.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
reed1
4 years, 7 months ago (2016-05-26 18:56:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012943003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2012943003/1
4 years, 7 months ago (2016-05-26 18:56:12 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 19:13:30 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/497290824f8d2eb6705fd2785e1851cecf9e2b03

Powered by Google App Engine
This is Rietveld 408576698