Enable sending frame-specific messages to the correct input router.

Enable sending frame-specific messages to the correct input router.

Presently RenderFrameHostImpl::Send() does not use its own widget's
input router when sending message, meaning messages to subframes could
be sent to the wrong frame. This was discovered while trying to make
InputMsg_SelectRange/InputHostMsg_SelectRange_Ack work properly for
messages sent to an out-of-process iframe.

BUG=470662
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/7a22bf01ea55475b295e40f5bbfd1add2bc73649
Cr-Commit-Position: refs/heads/master@{#396044}

[wjmaclean, 2016-05-25 21:37:57]

Description was changed from

==========
Enable sending frame-specific messages to the correct input router.

Presently RenderFrameHostImpl::Send() does not use its own widget's
input router when sending message, meaning messages to subframes could
be sent to the wrong frame. This was discovered while trying to make
InputMsg_SelectRange/InputHostMsg_SelectRange_Ack work properly for
messages sent to an out-of-process iframe.

BUG=none
==========

to

==========
Enable sending frame-specific messages to the correct input router.

Presently RenderFrameHostImpl::Send() does not use its own widget's
input router when sending message, meaning messages to subframes could
be sent to the wrong frame. This was discovered while trying to make
InputMsg_SelectRange/InputHostMsg_SelectRange_Ack work properly for
messages sent to an out-of-process iframe.

BUG=none
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[wjmaclean, 2016-05-25 21:39:45]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-25 21:40:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2012933002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2012933002/1

[wjmaclean, 2016-05-25 23:15:19]

Description was changed from

==========
Enable sending frame-specific messages to the correct input router.

Presently RenderFrameHostImpl::Send() does not use its own widget's
input router when sending message, meaning messages to subframes could
be sent to the wrong frame. This was discovered while trying to make
InputMsg_SelectRange/InputHostMsg_SelectRange_Ack work properly for
messages sent to an out-of-process iframe.

BUG=none
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Enable sending frame-specific messages to the correct input router.

Presently RenderFrameHostImpl::Send() does not use its own widget's
input router when sending message, meaning messages to subframes could
be sent to the wrong frame. This was discovered while trying to make
InputMsg_SelectRange/InputHostMsg_SelectRange_Ack work properly for
messages sent to an out-of-process iframe.

BUG=none
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[wjmaclean, 2016-05-25 23:15:19]

wjmaclean@chromium.org changed reviewers:
+ creis@chromium.org

[wjmaclean, 2016-05-25 23:15:56]

Tiny CL, please take a look? (This is part of the TouchSelection for OOPIF
work.)

[Charlie Reis, 2016-05-25 23:33:10]

Yeah, that was definitely broken.  Fix LGTM.  Can we add a test for this, or
will there be tests coming with the touch selection work?

Also, please list a bug for this CL.  Seems like it falls under 470662?

[Charlie Reis, 2016-05-25 23:33:37]

[+site-isolation-reviews]

[wjmaclean, 2016-05-25 23:40:45]

On 2016/05/25 23:33:37, Charlie Reis wrote:
> [+site-isolation-reviews]

Yes, there will be tests with oopif touch selection that will definitely pick up
on this if it breaks.

[commit-bot: I haz the power, 2016-05-25 23:41:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-25 23:41:31]

Dry run: This issue passed the CQ dry run.

[commit-bot: I haz the power, 2016-05-25 23:41:53]

Dry run: None

[wjmaclean, 2016-05-25 23:42:30]

Description was changed from

==========
Enable sending frame-specific messages to the correct input router.

Presently RenderFrameHostImpl::Send() does not use its own widget's
input router when sending message, meaning messages to subframes could
be sent to the wrong frame. This was discovered while trying to make
InputMsg_SelectRange/InputHostMsg_SelectRange_Ack work properly for
messages sent to an out-of-process iframe.

BUG=none
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Enable sending frame-specific messages to the correct input router.

Presently RenderFrameHostImpl::Send() does not use its own widget's
input router when sending message, meaning messages to subframes could
be sent to the wrong frame. This was discovered while trying to make
InputMsg_SelectRange/InputHostMsg_SelectRange_Ack work properly for
messages sent to an out-of-process iframe.

BUG=470662
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[wjmaclean, 2016-05-25 23:42:40]

The CQ bit was checked by wjmaclean@chromium.org

[commit-bot: I haz the power, 2016-05-25 23:43:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2012933002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2012933002/1

[commit-bot: I haz the power, 2016-05-25 23:49:58]

Description was changed from

==========
Enable sending frame-specific messages to the correct input router.

Presently RenderFrameHostImpl::Send() does not use its own widget's
input router when sending message, meaning messages to subframes could
be sent to the wrong frame. This was discovered while trying to make
InputMsg_SelectRange/InputHostMsg_SelectRange_Ack work properly for
messages sent to an out-of-process iframe.

BUG=470662
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Enable sending frame-specific messages to the correct input router.

Presently RenderFrameHostImpl::Send() does not use its own widget's
input router when sending message, meaning messages to subframes could
be sent to the wrong frame. This was discovered while trying to make
InputMsg_SelectRange/InputHostMsg_SelectRange_Ack work properly for
messages sent to an out-of-process iframe.

BUG=470662
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-05-25 23:49:59]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-25 23:51:39]

Description was changed from

==========
Enable sending frame-specific messages to the correct input router.

Presently RenderFrameHostImpl::Send() does not use its own widget's
input router when sending message, meaning messages to subframes could
be sent to the wrong frame. This was discovered while trying to make
InputMsg_SelectRange/InputHostMsg_SelectRange_Ack work properly for
messages sent to an out-of-process iframe.

BUG=470662
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Enable sending frame-specific messages to the correct input router.

Presently RenderFrameHostImpl::Send() does not use its own widget's
input router when sending message, meaning messages to subframes could
be sent to the wrong frame. This was discovered while trying to make
InputMsg_SelectRange/InputHostMsg_SelectRange_Ack work properly for
messages sent to an out-of-process iframe.

BUG=470662
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/7a22bf01ea55475b295e40f5bbfd1add2bc73649
Cr-Commit-Position: refs/heads/master@{#396044}
==========

[commit-bot: I haz the power, 2016-05-25 23:51:41]

Patchset 1 (id:??) landed as
https://crrev.com/7a22bf01ea55475b295e40f5bbfd1add2bc73649
Cr-Commit-Position: refs/heads/master@{#396044}

[Charlie Reis, 2016-05-26 16:55:31]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2006423005/ by creis@chromium.org.

The reason for reverting is: Caused crashes because RFH::GetRenderWidgetHost()
returns null unless the frame owns its own widget.  See
https://crbug.com/614952..

[wjmaclean, 2016-05-30 21:46:03]

Patchset #2 (id:20001) has been deleted

[wjmaclean, 2016-09-08 17:47:33]

On 2016/05/26 16:55:31, Charlie Reis wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/2006423005/ by mailto:creis@chromium.org.
> 
> The reason for reverting is: Caused crashes because RFH::GetRenderWidgetHost()
> returns null unless the frame owns its own widget.  See
> https://crbug.com/614952..

creis@ - This is needed for the TouchSelection work, and since kenrb@'s fix for
the null return value from GetRenderWidgetHost() has landed (see
https://codereview.chromium.org/2023453003), is it OK if I rebase this and try
to land it again?

[Charlie Reis, 2016-09-09 00:01:09]

On 2016/09/08 17:47:33, wjmaclean wrote:
> On 2016/05/26 16:55:31, Charlie Reis wrote:
> > A revert of this CL (patchset #1 id:1) has been created in
> > https://codereview.chromium.org/2006423005/ by mailto:creis@chromium.org.
> > 
> > The reason for reverting is: Caused crashes because
RFH::GetRenderWidgetHost()
> > returns null unless the frame owns its own widget.  See
> > https://crbug.com/614952..
> 
> creis@ - This is needed for the TouchSelection work, and since kenrb@'s fix
for
> the null return value from GetRenderWidgetHost() has landed (see
> https://codereview.chromium.org/2023453003), is it OK if I rebase this and try
> to land it again?

Yes, let's reland!