Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: Source/devtools/front_end/DebuggerModel.js

Issue 201293007: DevTools: Remove step into selection experiment (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebaselined Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/devtools/front_end/JavaScriptSourceFrame.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/DebuggerModel.js
diff --git a/Source/devtools/front_end/DebuggerModel.js b/Source/devtools/front_end/DebuggerModel.js
index 67e47e721a32ca6fe0004f0a9a89c5c6492781bc..be1728b66a5302da4b5e7e646f5d9c2f121f45fd 100644
--- a/Source/devtools/front_end/DebuggerModel.js
+++ b/Source/devtools/front_end/DebuggerModel.js
@@ -199,25 +199,6 @@ WebInspector.DebuggerModel.prototype = {
this._agent.continueToLocation(rawLocation);
},
- /**
- * @param {!WebInspector.DebuggerModel.Location} rawLocation
- */
- stepIntoSelection: function(rawLocation)
- {
- /**
- * @param {!WebInspector.DebuggerModel.Location} requestedLocation
- * @param {?string} error
- * @this {WebInspector.DebuggerModel}
- */
- function callback(requestedLocation, error)
- {
- if (error)
- return;
- this._pendingStepIntoLocation = requestedLocation;
- };
- this._agent.continueToLocation(rawLocation, true, callback.bind(this, rawLocation));
- },
-
stepInto: function()
{
/**
@@ -482,19 +463,6 @@ WebInspector.DebuggerModel.prototype = {
*/
_pausedScript: function(callFrames, reason, auxData, breakpointIds, asyncStackTrace)
{
- if (this._pendingStepIntoLocation) {
- var requestedLocation = this._pendingStepIntoLocation;
- delete this._pendingStepIntoLocation;
-
- if (callFrames.length > 0) {
- var topLocation = callFrames[0].location;
- if (topLocation.lineNumber == requestedLocation.lineNumber && topLocation.columnNumber == requestedLocation.columnNumber && topLocation.scriptId == requestedLocation.scriptId) {
- this.stepInto();
- return;
- }
- }
- }
-
this._setDebuggerPausedDetails(new WebInspector.DebuggerPausedDetails(this, callFrames, reason, auxData, breakpointIds, asyncStackTrace));
},
@@ -979,30 +947,6 @@ WebInspector.DebuggerModel.CallFrame.prototype = {
},
/**
- * @param {function(!Array.<!DebuggerAgent.Location>)} callback
- */
- getStepIntoLocations: function(callback)
- {
- if (this._stepInLocations) {
- callback(this._stepInLocations.slice(0));
- return;
- }
- /**
- * @param {?string} error
- * @param {!Array.<!DebuggerAgent.Location>=} stepInPositions
- * @this {WebInspector.DebuggerModel.CallFrame}
- */
- function getStepInPositionsCallback(error, stepInPositions)
- {
- if (error)
- return;
- this._stepInLocations = stepInPositions;
- callback(this._stepInLocations.slice(0));
- }
- this._debuggerAgent.getStepInPositions(this.id, getStepInPositionsCallback.bind(this));
- },
-
- /**
* @param {function(!WebInspector.UILocation):(boolean|undefined)} updateDelegate
* @return {!WebInspector.LiveLocation}
*/
« no previous file with comments | « no previous file | Source/devtools/front_end/JavaScriptSourceFrame.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698