Source/core/html/HTMLObjectElement.cpp - Issue 201293002: Add Traversal<*Element>::firstAncestor() API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLObjectElement.cpp

Issue 201293002: Add Traversal<*Element>::firstAncestor() API (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix editing failures Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/HTMLFormControlElement.cpp ('K') | « Source/core/html/HTMLFrameSetElement.cpp ('k') | Source/core/html/HTMLOptGroupElement.cpp » ('j') | Source/core/html/parser/HTMLTreeBuilder.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLObjectElement.cpp

diff --git a/Source/core/html/HTMLObjectElement.cpp b/Source/core/html/HTMLObjectElement.cpp

index b92e993d5a0690df3247ac7fec4dcea7a23a6f12..88a138ed94efc87de48563ebc8acd4d61bc25b69 100644

--- a/Source/core/html/HTMLObjectElement.cpp

+++ b/Source/core/html/HTMLObjectElement.cpp

@@ -423,8 +423,8 @@ void HTMLObjectElement::renderFallbackContent()

bool HTMLObjectElement::isExposed() const

{

// http://www.whatwg.org/specs/web-apps/current-work/#exposed

- for (Node* ancestor = parentNode(); ancestor; ancestor = ancestor->parentNode()) {

- if (isHTMLObjectElement(*ancestor) && toHTMLObjectElement(ancestor)->isExposed())

+ for (HTMLObjectElement* ancestor = Traversal<HTMLObjectElement>::firstAncestor(*this); ancestor; ancestor = Traversal<HTMLObjectElement>::firstAncestor(*ancestor)) {

+ if (ancestor->isExposed())

return false;

}

for (HTMLElement* element = Traversal<HTMLElement>::firstWithin(*this); element; element = Traversal<HTMLElement>::next(*element, this)) {