Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(892)

Unified Diff: Source/core/rendering/RenderObject.cpp

Issue 201293002: Add Traversal<*Element>::firstAncestor() API (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Slight clean up Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderObject.cpp
diff --git a/Source/core/rendering/RenderObject.cpp b/Source/core/rendering/RenderObject.cpp
index e6e9ba7dd2d924a948810eb49b63cea2e2e36ec5..a13c4af7cd30784944663d9f79b8f760412312ab 100644
--- a/Source/core/rendering/RenderObject.cpp
+++ b/Source/core/rendering/RenderObject.cpp
@@ -2958,8 +2958,8 @@ PassRefPtr<RenderStyle> RenderObject::getUncachedPseudoStyle(const PseudoStyleRe
// FIXME: This "find nearest element parent" should be a helper function.
Node* n = node();
- while (n && !n->isElementNode())
- n = n->parentNode();
+ if (n && !n->isElementNode())
+ n = ElementTraversal::firstAncestor(*n);
esprehn 2014/03/21 07:58:33 This just makes this code slower and more complica
Inactive 2014/03/21 14:37:24 Kept this change out.
if (!n)
return nullptr;
Element* element = toElement(n);
« Source/core/editing/FrameSelection.cpp ('K') | « Source/core/html/parser/HTMLTreeBuilder.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698