Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Unified Diff: Source/core/html/HTMLFrameSetElement.cpp

Issue 201293002: Add Traversal<*Element>::firstAncestor() API (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Slight clean up Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLFrameSetElement.cpp
diff --git a/Source/core/html/HTMLFrameSetElement.cpp b/Source/core/html/HTMLFrameSetElement.cpp
index 37b4cd192da12f3691dabaa60d6d0c45c3011fa4..d3f727934bc59489ca1e05ddcfec87ca1439031d 100644
--- a/Source/core/html/HTMLFrameSetElement.cpp
+++ b/Source/core/html/HTMLFrameSetElement.cpp
@@ -169,21 +169,17 @@ void HTMLFrameSetElement::attach(const AttachContext& context)
{
// Inherit default settings from parent frameset
// FIXME: This is not dynamic.
- for (ContainerNode* node = parentNode(); node; node = node->parentNode()) {
- if (isHTMLFrameSetElement(*node)) {
- HTMLFrameSetElement& frameset = toHTMLFrameSetElement(*node);
- if (!m_frameborderSet)
- m_frameborder = frameset.hasFrameBorder();
- if (m_frameborder) {
- if (!m_borderSet)
- m_border = frameset.border();
- if (!m_borderColorSet)
- m_borderColorSet = frameset.hasBorderColor();
- }
- if (!m_noresize)
- m_noresize = frameset.noResize();
- break;
+ if (HTMLFrameSetElement* frameset = Traversal<HTMLFrameSetElement>::firstAncestor(*this)) {
+ if (!m_frameborderSet)
+ m_frameborder = frameset->hasFrameBorder();
+ if (m_frameborder) {
+ if (!m_borderSet)
+ m_border = frameset->border();
+ if (!m_borderColorSet)
+ m_borderColorSet = frameset->hasBorderColor();
}
+ if (!m_noresize)
+ m_noresize = frameset->noResize();
}
HTMLElement::attach(context);

Powered by Google App Engine
This is Rietveld 408576698