Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2012873002: [DevTools] Add fetch support for XHR breakpoints (Closed)

Created:
4 years, 6 months ago by kozy
Modified:
4 years, 6 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, haraken, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Add fetch support for XHR breakpoints BUG=614740 R=dgozman@chromium.org Committed: https://crrev.com/3cc776e8e1116741baba2f3754e99bfaf4e1c1dd Cr-Commit-Position: refs/heads/master@{#396088}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Messages

Total messages: 24 (9 generated)
kozy
Dmitry, please take a look!
4 years, 6 months ago (2016-05-25 19:03:58 UTC) #1
dgozman
lgtm https://codereview.chromium.org/2012873002/diff/1/third_party/WebKit/Source/modules/fetch/GlobalFetch.cpp File third_party/WebKit/Source/modules/fetch/GlobalFetch.cpp (right): https://codereview.chromium.org/2012873002/diff/1/third_party/WebKit/Source/modules/fetch/GlobalFetch.cpp#newcode55 third_party/WebKit/Source/modules/fetch/GlobalFetch.cpp:55: InspectorInstrumentation::willSendXMLHttpRequest(executionContext, r->url()); Let's rename this to |willIssueNetworkRequest|.
4 years, 6 months ago (2016-05-25 22:00:32 UTC) #2
kozy
All done. https://codereview.chromium.org/2012873002/diff/1/third_party/WebKit/Source/modules/fetch/GlobalFetch.cpp File third_party/WebKit/Source/modules/fetch/GlobalFetch.cpp (right): https://codereview.chromium.org/2012873002/diff/1/third_party/WebKit/Source/modules/fetch/GlobalFetch.cpp#newcode55 third_party/WebKit/Source/modules/fetch/GlobalFetch.cpp:55: InspectorInstrumentation::willSendXMLHttpRequest(executionContext, r->url()); On 2016/05/25 22:00:32, dgozman wrote: ...
4 years, 6 months ago (2016-05-25 22:24:31 UTC) #3
kozy
Pavel, please take a look. I need owner lgtm for GlobalFetch.
4 years, 6 months ago (2016-05-25 22:25:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2012873002/20001
4 years, 6 months ago (2016-05-25 22:26:46 UTC) #8
pfeldman
https://codereview.chromium.org/2012873002/diff/20001/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl File third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl (right): https://codereview.chromium.org/2012873002/diff/20001/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl#newcode119 third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl:119: void willIssueNetworkRequest(ExecutionContext*, const String& url); The instrumentation name is ...
4 years, 6 months ago (2016-05-25 22:32:18 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/190011)
4 years, 6 months ago (2016-05-25 22:38:40 UTC) #11
kozy
All done! https://codereview.chromium.org/2012873002/diff/20001/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl File third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl (right): https://codereview.chromium.org/2012873002/diff/20001/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl#newcode119 third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl:119: void willIssueNetworkRequest(ExecutionContext*, const String& url); On 2016/05/25 ...
4 years, 6 months ago (2016-05-25 22:44:45 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012873002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2012873002/40001
4 years, 6 months ago (2016-05-25 22:45:53 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-26 00:43:47 UTC) #16
commit-bot: I haz the power
Dry run: None
4 years, 6 months ago (2016-05-26 00:44:06 UTC) #17
pfeldman
lgtm
4 years, 6 months ago (2016-05-26 01:22:38 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012873002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2012873002/40001
4 years, 6 months ago (2016-05-26 02:14:52 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-05-26 02:20:03 UTC) #22
commit-bot: I haz the power
4 years, 6 months ago (2016-05-26 02:21:32 UTC) #24
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/3cc776e8e1116741baba2f3754e99bfaf4e1c1dd
Cr-Commit-Position: refs/heads/master@{#396088}

Powered by Google App Engine
This is Rietveld 408576698