Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2012853003: Reland of Pass SequencedTaskRunner to PowerSaveBlocker for ui/file ops (Closed)

Created:
4 years, 7 months ago by scottmg
Modified:
4 years, 7 months ago
CC:
chromium-reviews, asanka, devtools-reviews_chromium.org, jam, imcheng+watch_chromium.org, droger+watchlist_chromium.org, extensions-reviews_chromium.org, jasonroberts+watch_google.com, sdefresne+watchlist_chromium.org, avayvod+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, blundell+watchlist_chromium.org, loading-reviews_chromium.org, chromium-apps-reviews_chromium.org, xjz+watch_chromium.org, isheriff+watch_chromium.org, pfeldman, miu+watch_chromium.org, asargent_no_longer_on_chrome, tommi (sloooow) - chröme
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Pass SequencedTaskRunner to PowerSaveBlocker for ui/file ops This is a reland of https://codereview.chromium.org/1991593002/, the diff is PS1 -> PS2, and passes a SingleThreadTaskRunner for _x11 (for DBus), rather than just a SequencedTaskRunner. R=nick,hashimoto TBR=asargent,tommi BUG=612337, 257943, 612563, 614629 Committed: https://crrev.com/e132b810a0e3c898705bcd70c7fa93da70482d13 Cr-Commit-Position: refs/heads/master@{#396189}

Patch Set 1 #

Patch Set 2 : SingleThreadTaskRunner for _x11 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+267 lines, -140 lines) Patch
M chrome/browser/media/cast_transport_host_filter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/drive/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M components/drive/drive_uploader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/DEPS View 2 chunks +10 lines, -2 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/download/download_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/download/download_request_core.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/loader/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/power_save_block_resource_throttle.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/media/capture/aura_window_capture_machine.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/media/capture/desktop_capture_device.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/media/media_web_contents_observer.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M content/browser/media/webrtc/webrtc_internals.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/power_save_blocker_android.cc View 1 6 chunks +22 lines, -14 lines 0 comments Download
M content/browser/power_save_blocker_chromeos.cc View 1 4 chunks +24 lines, -13 lines 0 comments Download
A content/browser/power_save_blocker_factory.cc View 1 1 chunk +22 lines, -0 lines 0 comments Download
M content/browser/power_save_blocker_impl.h View 1 3 chunks +11 lines, -3 lines 0 comments Download
M content/browser/power_save_blocker_impl.cc View 1 1 chunk +10 lines, -7 lines 0 comments Download
M content/browser/power_save_blocker_mac.cc View 1 1 chunk +9 lines, -4 lines 0 comments Download
M content/browser/power_save_blocker_ozone.cc View 1 1 chunk +9 lines, -5 lines 0 comments Download
M content/browser/power_save_blocker_win.cc View 1 5 chunks +24 lines, -17 lines 0 comments Download
M content/browser/power_save_blocker_x11.cc View 1 16 chunks +55 lines, -40 lines 0 comments Download
M content/browser/wake_lock/wake_lock_service_context.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/content_browser.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M content/public/browser/power_save_blocker.h View 1 2 chunks +7 lines, -2 lines 0 comments Download
A content/public/browser/power_save_blocker_factory.h View 1 chunk +25 lines, -0 lines 0 comments Download
M extensions/browser/api/power/power_api.cc View 3 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
scottmg
4 years, 7 months ago (2016-05-25 19:08:28 UTC) #6
ncarter (slow)
ps1 vs ps2 lgtm.
4 years, 7 months ago (2016-05-25 21:22:22 UTC) #7
hashimoto
lgtm
4 years, 7 months ago (2016-05-26 00:42:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012853003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2012853003/20001
4 years, 7 months ago (2016-05-26 15:47:18 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-26 15:52:01 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 15:53:32 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e132b810a0e3c898705bcd70c7fa93da70482d13
Cr-Commit-Position: refs/heads/master@{#396189}

Powered by Google App Engine
This is Rietveld 408576698