Remove use of search API; effectively remove support to search for task by name.

appengine/swarming/server/task_scheduler.py

 # Copyright 2014 The LUCI Authors. All rights reserved.
 # Use of this source code is governed under the Apache License, Version 2.0
 # that can be found in the LICENSE file.
 
 """High level tasks execution scheduling API.
 
 This is the interface closest to the HTTP handlers.
 """
 
 import contextlib
 import datetime
 import logging
 import math
 import random
 
 from google.appengine.api import datastore_errors
-from google.appengine.api import search
 from google.appengine.ext import ndb
 from google.appengine.runtime import apiproxy_errors
 
 from components import datastore_utils
 from components import pubsub
 from components import utils
 import ts_mon_metrics
 from server import config
 from server import stats
 from server import task_pack
@@ skipping 376 matching lines @@
   # At this point, the request is now in the DB but not yet in a mode where it
   # can be triggered or visible. Index it right away so it is searchable. If any
   # of remaining calls in this function fail, the TaskRequest and Search
   # Document will simply point to an incomplete task, which will be ignored.
   #
   # Creates the entities TaskToRun and TaskResultSummary but do not save them
   # yet. TaskRunResult will be created once a bot starts it.
   task = task_to_run.new_task_to_run(request)
   result_summary = task_result.new_result_summary(request)
 
-  # Do not specify a doc_id, as they are guaranteed to be monotonically
-  # increasing and searches are done in reverse order, which fits exactly the
-  # created_ts ordering. This is useful because DateField is precise to the date
-  # (!) and NumberField is signed 32 bits so the best it could do with EPOCH is
-  # second resolution up to year 2038.
-  index = search.Index(name='requests')
-  packed = task_pack.pack_result_summary_key(result_summary.key)
-  doc = search.Document(
-      fields=[
-        search.TextField(name='name', value=request.name),
-        search.AtomField(name='id', value=packed),
-      ])
-  # Even if it fails here, we're still fine, as the task is not "alive" yet.
-  search_future = index.put_async([doc])
-
   now = utils.utcnow()
 
   if dupe_future:
     # Reuse the results!
     dupe_summary = dupe_future.get_result()
     # Refuse tasks older than X days. This is due to the isolate server dropping
     # files. https://code.google.com/p/swarming/issues/detail?id=197
     oldest = now - datetime.timedelta(
         seconds=config.settings().reusable_task_age_secs)
     if dupe_summary and dupe_summary.created_ts > oldest:
@@ skipping 37 matching lines @@
     for item in items:
       item.children_task_ids.append(k)
       item.modified_ts = now
     ndb.put_multi(items)
 
   # Raising will abort to the caller.
   futures = [datastore_utils.transaction_async(run)]
   if parent_task_keys:
     futures.append(datastore_utils.transaction_async(run_parent))
 
-  try:
-    search_future.get_result()
-  except search.Error:
-    # Do not abort the task, for now search is best effort.
-    logging.exception('Put failed')
-
   for future in futures:
     # Check for failures, it would raise in this case, aborting the call.
     future.get_result()
 
   stats.add_task_entry(
       'task_enqueued', result_summary.key,
       dimensions=request.properties.dimensions,
       user=request.user)
   return result_summary
 
@@ skipping 390 matching lines @@
 ## Task queue tasks.
 
 
 def task_handle_pubsub_task(payload):
   """Handles task enqueued by _maybe_pubsub_notify_via_tq."""
   # Do not catch errors to trigger task queue task retry. Errors should not
   # happen in normal case.
   _pubsub_notify(
       payload['task_id'], payload['topic'],
       payload['auth_token'], payload['userdata'])