Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2012843003: Remove use of search API; effectively remove support to search for task by name. (Closed)

Created:
4 years, 7 months ago by M-A Ruel
Modified:
4 years, 7 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Base URL:
git@github.com:luci/luci-py.git@master
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Remove use of search API; effectively remove support to search for task by name. The search API is flaky and slow and barely maintained. This is not an essential Swarming feature and tags (which were developped later) are a much faster and more powerful alternative. The Swarming Cloud Endpoints API never supported searching by task name, as cursor handling is problematic. R=vadimsh@chromium.org BUG= Committed: https://github.com/luci/luci-py/commit/28f6609def9e16e5afc880a4f5b17996c74d215d

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -249 lines) Patch
M appengine/swarming/handlers_frontend.py View 6 chunks +8 lines, -12 lines 0 comments Download
M appengine/swarming/handlers_test.py View 1 chunk +0 lines, -9 lines 0 comments Download
M appengine/swarming/server/task_result.py View 3 chunks +0 lines, -94 lines 0 comments Download
M appengine/swarming/server/task_result_test.py View 1 chunk +0 lines, -4 lines 0 comments Download
M appengine/swarming/server/task_scheduler.py View 3 chunks +0 lines, -22 lines 0 comments Download
M appengine/swarming/server/task_scheduler_test.py View 3 chunks +0 lines, -94 lines 0 comments Download
M appengine/swarming/templates/user_tasks.html View 3 chunks +0 lines, -13 lines 0 comments Download
M appengine/swarming/test_env_handlers.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
M-A Ruel
4 years, 7 months ago (2016-05-26 01:02:56 UTC) #3
Vadim Sh.
lgtm We should also probably wipe search index later. I think they charge per stored ...
4 years, 7 months ago (2016-05-26 01:06:55 UTC) #4
M-A Ruel
On 2016/05/26 01:06:55, Vadim Sh. wrote: > We should also probably wipe search index later. ...
4 years, 7 months ago (2016-05-26 01:14:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012843003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2012843003/20001
4 years, 7 months ago (2016-05-26 01:15:11 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001) as https://github.com/luci/luci-py/commit/28f6609def9e16e5afc880a4f5b17996c74d215d
4 years, 7 months ago (2016-05-26 01:18:14 UTC) #9
M-A Ruel
4 years, 7 months ago (2016-05-26 01:26:53 UTC) #10
Message was sent while issue was closed.
Oops, I forgot the tracking bug is http://crbug.com/614811.

Powered by Google App Engine
This is Rietveld 408576698