third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp - Issue 2012823003: Move IME related functions from WebFrame to WebLocalFrame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

Issue 2012823003: Move IME related functions from WebFrame to WebLocalFrame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove null check in spellcheck_provider.cc and add some log Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/page/FocusController.cpp ('K') | « third_party/WebKit/Source/core/page/FocusController.cpp ('k') | third_party/WebKit/Source/web/WebRemoteFrameImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

index 5b8b0654e78eb10ef558300e1352531057ca82be..e09d4bcc5fde6394184a463589c10124c5c21497 100644

--- a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

+++ b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

@@ -911,11 +911,11 @@ WebInputEventResult WebFrameWidgetImpl::keyEventDefault(const WebKeyboardEvent&

switch (event.windowsKeyCode) {

#if !OS(MACOSX)

case 'A':

- WebFrame::fromFrame(focusedCoreFrame())->executeCommand(WebString::fromUTF8("SelectAll"));

+ WebFrame::fromFrame(focusedCoreFrame())->toWebLocalFrame()->executeCommand(WebString::fromUTF8("SelectAll"));

return WebInputEventResult::HandledSystem;

case VKEY_INSERT:

case 'C':

- WebFrame::fromFrame(focusedCoreFrame())->executeCommand(WebString::fromUTF8("Copy"));

+ WebFrame::fromFrame(focusedCoreFrame())->toWebLocalFrame()->executeCommand(WebString::fromUTF8("Copy"));

return WebInputEventResult::HandledSystem;

#endif

// Match FF behavior in the sense that Ctrl+home/end are the only Ctrl