third_party/WebKit/Source/core/page/FocusController.cpp - Issue 2012823003: Move IME related functions from WebFrame to WebLocalFrame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/FocusController.cpp

Issue 2012823003: Move IME related functions from WebFrame to WebLocalFrame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove null check in spellcheck_provider.cc and add some log Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/spellchecker/spellcheck_provider.cc ('K') | « content/renderer/text_input_client_observer.cc ('k') | third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/FocusController.cpp

diff --git a/third_party/WebKit/Source/core/page/FocusController.cpp b/third_party/WebKit/Source/core/page/FocusController.cpp

index f0388e2a568fb19f01d856d077c2850591d3bf15..b38b8e2466de80e194977c628af6b75d3511d2be 100644

--- a/third_party/WebKit/Source/core/page/FocusController.cpp

+++ b/third_party/WebKit/Source/core/page/FocusController.cpp

@@ -798,6 +798,7 @@ Frame* FocusController::focusedOrMainFrame() const

return frame;

}

yabinh 2016/06/22 13:34:50 Sometimes it returns a remote frame. In the build:

+ LOG(ERROR) << "hyb: m_page->mainFrame()->isRemoteFrame() = " << m_page->mainFrame()->isRemoteFrame();

return m_page->mainFrame();

}