components/printing/renderer/print_web_view_helper.cc - Issue 2012823003: Move IME related functions from WebFrame to WebLocalFrame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/printing/renderer/print_web_view_helper.cc

Issue 2012823003: Move IME related functions from WebFrame to WebLocalFrame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove null check in spellcheck_provider.cc and add some log Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/spellchecker/spellcheck_provider.cc ('K') | « chrome/renderer/spellchecker/spellcheck_provider.cc ('k') | components/test_runner/test_runner_for_specific_view.cc » ('j') | third_party/WebKit/Source/core/page/FocusController.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/printing/renderer/print_web_view_helper.cc

diff --git a/components/printing/renderer/print_web_view_helper.cc b/components/printing/renderer/print_web_view_helper.cc

index fa79d1a2714353a0a665ff0e7f4c77d78738f0ea..a8ec39d8500e048a0c312034dc4c1e8b97d7c2af 100644

--- a/components/printing/renderer/print_web_view_helper.cc

+++ b/components/printing/renderer/print_web_view_helper.cc

@@ -955,8 +955,7 @@ bool PrintWebViewHelper::GetPrintFrame(blink::WebLocalFrame** frame) {

// If the user has selected text in the currently focused frame we print

// only that frame (this makes print selection work for multiple frames).

- blink::WebLocalFrame* focusedFrame =

- webView->focusedFrame()->toWebLocalFrame();

+ blink::WebLocalFrame* focusedFrame = webView->focusedFrame();

*frame = focusedFrame->hasSelection()

? focusedFrame

: webView->mainFrame()->toWebLocalFrame();