third_party/WebKit/Source/web/tests/VisualViewportTest.cpp - Issue 2012823003: Move IME related functions from WebFrame to WebLocalFrame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

Issue 2012823003: Move IME related functions from WebFrame to WebLocalFrame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: sync Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/web/WebViewImpl.cpp ('K') | « third_party/WebKit/Source/web/WebViewImpl.cpp ('k') | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp b/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

index de41d3e91ce8ecd9b5bb46b2f2c9ee33fae80b21..3471fd824d73d6fad6f3ddd0178a1354eec20c3d 100644

--- a/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

+++ b/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

@@ -938,7 +938,7 @@ TEST_P(ParameterizedVisualViewportTest, DISABLED_TestWebFrameRangeAccountsForVis

// the range and its end). Do a sanity check that the expected text is

// selected

mainFrame->executeScript(WebScriptSource("selectRange();"));

- EXPECT_EQ("ir", mainFrame->selectionAsText().utf8());

+ EXPECT_EQ("ir", mainFrame->toWebLocalFrame()->selectionAsText().utf8());

webViewImpl()->selectionBounds(baseRect, extentRect);

WebPoint initialPoint(baseRect.x, baseRect.y);

@@ -949,8 +949,8 @@ TEST_P(ParameterizedVisualViewportTest, DISABLED_TestWebFrameRangeAccountsForVis

// the right and down one line.

VisualViewport& visualViewport = frame()->page()->frameHost().visualViewport();

visualViewport.move(FloatPoint(60, 25));

- mainFrame->moveRangeSelection(initialPoint, endPoint);

- EXPECT_EQ("t ", mainFrame->selectionAsText().utf8());

+ mainFrame->toWebLocalFrame()->moveRangeSelection(initialPoint, endPoint);

+ EXPECT_EQ("t ", mainFrame->toWebLocalFrame()->selectionAsText().utf8());

}

// Test that the scrollFocusedEditableElementIntoRect method works with the visual viewport.