Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 2012803003: Fix --use-gl=desktop for Windows. (Closed)

Created:
4 years, 7 months ago by Geoff Lang
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix --use-gl=desktop for Windows. New methods were added to SurfaceGL with default implementations containing UNIMPLEMENTEDs but the GLSurfaceWGL classes were not updated. BUG=614787 Committed: https://crrev.com/5ab7b65e8de91e56da67a1ed960c5eb509bf8053 Cr-Commit-Position: refs/heads/master@{#396001}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
M ui/gl/gl_surface_wgl.h View 2 chunks +6 lines, -0 lines 0 comments Download
M ui/gl/gl_surface_wgl.cc View 2 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Geoff Lang
PTAL
4 years, 7 months ago (2016-05-25 19:42:16 UTC) #2
Ken Russell (switch to Gerrit)
lgtm
4 years, 7 months ago (2016-05-25 20:06:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012803003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2012803003/1
4 years, 7 months ago (2016-05-25 20:10:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 22:08:08 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 22:09:45 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5ab7b65e8de91e56da67a1ed960c5eb509bf8053
Cr-Commit-Position: refs/heads/master@{#396001}

Powered by Google App Engine
This is Rietveld 408576698