Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2012793002:
[Telemetry] Remove BuildbotOutputFormatter (Closed)
|
Created:
4 years, 7 months ago by eakuefner Modified:
4 years, 4 months ago CC:
catapult-reviews_chromium.org, Camillo Bruni, kouhei (in TOK), petrcermak, Primiano Tucci (use gerrit), rnephew (Reviews Here), telemetry-reviews_chromium.org, ulan, vmiura Base URL:
git@github.com:catapult-project/catapult.git@master Target Ref:
refs/heads/master Project:
catapult Visibility:
Public. |
Description[Telemetry] Remove BuildbotOutputFormatter
BUG=chromium:477056
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/0fdcac0b5843b7002bee2f87b9af2f8d96ddba06
Patch Set 1 #
Messages
Total messages: 25 (11 generated)
nednguyen@google.com changed reviewers: + nednguyen@google.com
lgtm
Description was changed from ========== [WIP] [Telemetry] Remove BuildbotOutputFormatter BUG=catapult:# ========== to ========== [WIP] [Telemetry] Remove BuildbotOutputFormatter BUG=catapult:# ==========
On 2016/05/25 15:58:48, nednguyen wrote: > lgtm cc folks who are main customers of telemetry
eakuefner@chromium.org changed reviewers: + prasadv@chromium.org, robertocn@chromium.org
+ bisect folks
perezju@chromium.org changed reviewers: + perezju@chromium.org
\o/
Description was changed from ========== [WIP] [Telemetry] Remove BuildbotOutputFormatter BUG=catapult:# ========== to ========== [Telemetry] Remove BuildbotOutputFormatter BUG=catapult:# ==========
eakuefner@chromium.org changed reviewers: - perezju@chromium.org
The CQ bit was checked by nednguyen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2012793002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Pr...)
On 2016/05/31 18:59:21, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED, > https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Pr...) I remember we have a crbug about removing buildbot_output_formatter? It worths having a bug to keep track of removing this.
Description was changed from ========== [Telemetry] Remove BuildbotOutputFormatter BUG=catapult:# ========== to ========== [Telemetry] Remove BuildbotOutputFormatter BUG=chromium:477056 ==========
On 2016/05/31 at 19:13:42, nednguyen wrote: > On 2016/05/31 18:59:21, commit-bot: I haz the power wrote: > > Try jobs failed on following builders: > > Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED, > > https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Pr...) > > I remember we have a crbug about removing buildbot_output_formatter? It worths having a bug to keep track of removing this. I found the Chromium bug and set it as BUG= and I'll work on landing this today. I want to make sure I haven't missed anything before I check the box.
On 2016/06/07 17:35:00, eakuefner wrote: > On 2016/05/31 at 19:13:42, nednguyen wrote: > > On 2016/05/31 18:59:21, commit-bot: I haz the power wrote: > > > Try jobs failed on following builders: > > > Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED, > > > > https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Pr...) > > > > I remember we have a crbug about removing buildbot_output_formatter? It worths > having a bug to keep track of removing this. > > I found the Chromium bug and set it as BUG= and I'll work on landing this today. > I want to make sure I haven't missed anything before I check the box. ping?
The CQ bit was checked by eakuefner@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012793002/1
Message was sent while issue was closed.
Description was changed from ========== [Telemetry] Remove BuildbotOutputFormatter BUG=chromium:477056 ========== to ========== [Telemetry] Remove BuildbotOutputFormatter BUG=chromium:477056 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2064753008/ by nednguyen@google.com. The reason for reverting is: Other team is still using it..
Message was sent while issue was closed.
On 2016/06/15 21:42:10, nednguyen wrote: > A revert of this CL (patchset #1 id:1) has been created in > https://codereview.chromium.org/2064753008/ by mailto:nednguyen@google.com. > > The reason for reverting is: Other team is still using it.. :-(
Message was sent while issue was closed.
Looks like crbug.com/620464 is fixed and we can reland. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
