third_party/WebKit/Source/modules/webaudio/PannerNode.h - Issue 2012773005: Simplify notification of a dirty listener.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/PannerNode.h

Issue 2012773005: Simplify notification of a dirty listener. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webaudio/PannerNode.h

diff --git a/third_party/WebKit/Source/modules/webaudio/PannerNode.h b/third_party/WebKit/Source/modules/webaudio/PannerNode.h

index 56d632d253103e910d26ef7e68f315a70609b483..920f0ea97bfc30362abb5582e97702ed8c306885 100644

--- a/third_party/WebKit/Source/modules/webaudio/PannerNode.h

+++ b/third_party/WebKit/Source/modules/webaudio/PannerNode.h

@@ -104,7 +104,6 @@ public:

void setConeOuterGain(double);

void markPannerAsDirty(unsigned);

- void updateDirtyState();

double tailTime() const override { return m_panner ? m_panner->tailTime() : 0; }

double latencyTime() const override { return m_panner ? m_panner->latencyTime() : 0; }

@@ -148,6 +147,7 @@ private:

bool isAzimuthElevationDirty() const { return m_isAzimuthElevationDirty; }

bool isDistanceConeGainDirty() const { return m_isDistanceConeGainDirty; }

+ void updateDirtyState();

// This Persistent doesn't make a reference cycle including the owner

// PannerNode.