Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2012773003: Add ax_gen dependency to app_list_presenter test targets (Closed)

Created:
4 years, 7 months ago by tapted
Modified:
4 years, 7 months ago
Reviewers:
Matt Giuca
CC:
chromium-reviews, tfarina, Matt Giuca, tapted, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ax_gen dependency to app_list_presenter test targets These targets all have files that #include view.h, which #includes ax_enums.h. Therefore, building these targets can not begin until ax_enums.h has been generated. Otherwise the compile can fail. The dependency was added to the non-test app_list_presenter target in r394074. That helped, but it didn't do enough. Example: https://build.chromium.org/p/chromium/builders/Win%20x64/builds/1001/ BUG=611898 Committed: https://crrev.com/f1bce9d0653131ac106bd31550b65e6672ecc1b8 Cr-Commit-Position: refs/heads/master@{#396150}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M ui/app_list/presenter/BUILD.gn View 2 chunks +8 lines, -0 lines 0 comments Download
M ui/app_list/presenter/app_list_presenter.gyp View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
tapted
Hiya Matt, please take a look.
4 years, 7 months ago (2016-05-26 00:32:37 UTC) #4
Matt Giuca
lgtm Sorry I missed this.
4 years, 7 months ago (2016-05-26 08:41:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012773003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2012773003/1
4 years, 7 months ago (2016-05-26 08:41:43 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-26 08:45:25 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 08:46:21 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f1bce9d0653131ac106bd31550b65e6672ecc1b8
Cr-Commit-Position: refs/heads/master@{#396150}

Powered by Google App Engine
This is Rietveld 408576698