[tracing] Only add totals from discardable memory in background mode

[tracing] Only add totals from discardable memory in background mode

For background tracing mode only totals can be added to the trace to
keep traces light. So only add total numbers from discardable memory
dump provider.

BUG=613198
Committed: https://crrev.com/cc85367ae9abe6221f7a5427689095157295a720
Cr-Commit-Position: refs/heads/master@{#397639}

[ssid, 2016-05-31 22:53:10]

ssid@chromium.org changed reviewers:
+ primiano@chromium.org, reveman@chromium.org

[ssid, 2016-05-31 22:53:10]

ptal, thanks.

[Primiano Tucci (use gerrit), 2016-06-02 19:31:41]

Not familiar with the code, honestly you know more than me here :)
Makes sense to me, let's wait for David.

https://codereview.chromium.org/2012763004/diff/1/content/common/host_discard...
File content/common/host_discardable_shared_memory_manager.cc (right):

https://codereview.chromium.org/2012763004/diff/1/content/common/host_discard...
content/common/host_discardable_shared_memory_manager.cc:231:
GetBytesAllocated());
can you call this without the lock?

[reveman, 2016-06-02 21:54:27]

code lgtm, assuming this is what we want in dumps for background mode

[ssid, 2016-06-03 00:11:53]

ssid@chromium.org changed reviewers:
+ avi@chromium.org

[ssid, 2016-06-03 00:11:54]

+avi ptal, thanks.

[Avi (use Gerrit), 2016-06-03 00:20:31]

lgtm

[ssid, 2016-06-03 00:27:47]

Thanks.

https://codereview.chromium.org/2012763004/diff/1/content/common/host_discard...
File content/common/host_discardable_shared_memory_manager.cc (right):

https://codereview.chromium.org/2012763004/diff/1/content/common/host_discard...
content/common/host_discardable_shared_memory_manager.cc:231:
GetBytesAllocated());
On 2016/06/02 19:31:41, Primiano Tucci wrote:
> can you call this without the lock?

Hmm, we can only be stalling the memory-infra thread with this lock.
If we are holding lock, then it just reads the value and returns. So, we are not
stalling other threads.

[ssid, 2016-06-03 00:27:58]

The CQ bit was checked by ssid@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-03 00:29:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2012763004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2012763004/1

[commit-bot: I haz the power, 2016-06-03 02:26:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-03 02:26:29]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[ssid, 2016-06-03 02:41:15]

The CQ bit was checked by ssid@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-03 02:42:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2012763004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2012763004/1

[commit-bot: I haz the power, 2016-06-03 03:43:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-03 03:43:20]

Dry run: This issue passed the CQ dry run.

[ssid, 2016-06-03 05:05:23]

The CQ bit was checked by ssid@chromium.org

[commit-bot: I haz the power, 2016-06-03 05:05:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2012763004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2012763004/1

[commit-bot: I haz the power, 2016-06-03 05:12:25]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-03 05:14:08]

Description was changed from

==========
[tracing] Only add totals from discardable memory in background mode

For background tracing mode only totals can be added to the trace to
keep traces light. So only add total numbers from discardable memory
dump provider.

BUG=613198
==========

to

==========
[tracing] Only add totals from discardable memory in background mode

For background tracing mode only totals can be added to the trace to
keep traces light. So only add total numbers from discardable memory
dump provider.

BUG=613198

Committed: https://crrev.com/cc85367ae9abe6221f7a5427689095157295a720
Cr-Commit-Position: refs/heads/master@{#397639}
==========

[commit-bot: I haz the power, 2016-06-03 05:14:09]

Patchset 1 (id:??) landed as
https://crrev.com/cc85367ae9abe6221f7a5427689095157295a720
Cr-Commit-Position: refs/heads/master@{#397639}