Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 2012763004: [tracing] Only add totals from discardable memory in background mode (Closed)

Created:
4 years, 7 months ago by ssid
Modified:
4 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@whitelist_mdp
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tracing] Only add totals from discardable memory in background mode For background tracing mode only totals can be added to the trace to keep traces light. So only add total numbers from discardable memory dump provider. BUG=613198 Committed: https://crrev.com/cc85367ae9abe6221f7a5427689095157295a720 Cr-Commit-Position: refs/heads/master@{#397639}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M content/child/child_discardable_shared_memory_manager.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M content/common/host_discardable_shared_memory_manager.cc View 1 chunk +10 lines, -0 lines 2 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 21 (8 generated)
ssid
ptal, thanks.
4 years, 6 months ago (2016-05-31 22:53:10 UTC) #2
Primiano Tucci (use gerrit)
Not familiar with the code, honestly you know more than me here :) Makes sense ...
4 years, 6 months ago (2016-06-02 19:31:41 UTC) #3
reveman
code lgtm, assuming this is what we want in dumps for background mode
4 years, 6 months ago (2016-06-02 21:54:27 UTC) #4
ssid
+avi ptal, thanks.
4 years, 6 months ago (2016-06-03 00:11:54 UTC) #6
Avi (use Gerrit)
lgtm
4 years, 6 months ago (2016-06-03 00:20:31 UTC) #7
ssid
Thanks. https://codereview.chromium.org/2012763004/diff/1/content/common/host_discardable_shared_memory_manager.cc File content/common/host_discardable_shared_memory_manager.cc (right): https://codereview.chromium.org/2012763004/diff/1/content/common/host_discardable_shared_memory_manager.cc#newcode231 content/common/host_discardable_shared_memory_manager.cc:231: GetBytesAllocated()); On 2016/06/02 19:31:41, Primiano Tucci wrote: > ...
4 years, 6 months ago (2016-06-03 00:27:47 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012763004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2012763004/1
4 years, 6 months ago (2016-06-03 00:29:36 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/223990)
4 years, 6 months ago (2016-06-03 02:26:29 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012763004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2012763004/1
4 years, 6 months ago (2016-06-03 02:42:19 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-03 03:43:20 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012763004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2012763004/1
4 years, 6 months ago (2016-06-03 05:05:43 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 05:12:25 UTC) #19
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 05:14:09 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc85367ae9abe6221f7a5427689095157295a720
Cr-Commit-Position: refs/heads/master@{#397639}

Powered by Google App Engine
This is Rietveld 408576698