third_party/WebKit/Source/platform/heap/MarkingVisitorImpl.h - Issue 2012763002: Add checks for per thread heap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/heap/MarkingVisitorImpl.h

Issue 2012763002: Add checks for per thread heap (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/heap/MarkingVisitorImpl.h

diff --git a/third_party/WebKit/Source/platform/heap/MarkingVisitorImpl.h b/third_party/WebKit/Source/platform/heap/MarkingVisitorImpl.h

index 1d9f58b9f7c6f240617f9f4160198ea846063250..572453b2668e44fa4ae223516bc97fd8aa707b49 100644

--- a/third_party/WebKit/Source/platform/heap/MarkingVisitorImpl.h

+++ b/third_party/WebKit/Source/platform/heap/MarkingVisitorImpl.h

@@ -41,6 +41,9 @@ protected:

ASSERT(ThreadState::current()->isInGC());

ASSERT(toDerived()->getMarkingMode() != Visitor::WeakProcessing);

+ // A GC should only mark the objects that belong in its heap.

+ DCHECK(&pageFromObject(objectPointer)->arena()->getThreadState()->heap() == &toDerived()->heap());

header->mark();

if (callback)