Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2012743002:
[perf] Re-enable system_health.memory_* benchmarks (Closed)
|
Created:
4 years, 7 months ago by petrcermak Modified:
4 years, 6 months ago Reviewers:
sullivan CC:
chromium-reviews, telemetry-reviews_chromium.org, dtu, aiolos (Not reviewing), primiano CORP (USE chromium) Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[perf] Re-enable system_health.memory_* benchmarks
Hopefully, the perf dashboard infrastructure will now be able to handle
the amount of data generated by the benchmark.
Nevertheless, we throw away all Numeric statistics (standard deviation,
sum, count, max, min and percentiles) except for the average using the
trick from https://codereview.chromium.org/2005233002/. This should
reduce the amount of data pushed to the dashboard approximately 6 times.
BUG=589726, 610962, 617117
,catapult:#2340
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
Committed: https://crrev.com/55b6d5131d5b10e49fc37bb8cd9143d8a5765143
Cr-Commit-Position: refs/heads/master@{#398621}
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Remove Flipkart from the storyset #
Messages
Total messages: 40 (23 generated)
Description was changed from ========== [perf] Re-enable system_health.memory_* benchmarks Hopefully, the perf dashboard infrastructure will now be able to handle the amount of data generated by the benchmark. Nevertheless, we throw away all Numeric statistics (standard deviation, sum, count, max, min and percentiles) except for the average using the trick from https://codereview.chromium.org/2005233002/. This should reduce the amount of data pushed to the dashboard approximately 6 times. BUG=589726,610962,catapult:#2340 ========== to ========== [perf] Re-enable system_health.memory_* benchmarks Hopefully, the perf dashboard infrastructure will now be able to handle the amount of data generated by the benchmark. Nevertheless, we throw away all Numeric statistics (standard deviation, sum, count, max, min and percentiles) except for the average using the trick from https://codereview.chromium.org/2005233002/. This should reduce the amount of data pushed to the dashboard approximately 6 times. BUG=589726,610962,catapult:#2340 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ==========
petrcermak@chromium.org changed reviewers: + sullivan@chromium.org
As discussed yesterday, let's try to re-enable the memory system health benchmarks today and see what happens. Petr
Description was changed from ========== [perf] Re-enable system_health.memory_* benchmarks Hopefully, the perf dashboard infrastructure will now be able to handle the amount of data generated by the benchmark. Nevertheless, we throw away all Numeric statistics (standard deviation, sum, count, max, min and percentiles) except for the average using the trick from https://codereview.chromium.org/2005233002/. This should reduce the amount of data pushed to the dashboard approximately 6 times. BUG=589726,610962,catapult:#2340 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== [perf] Re-enable system_health.memory_* benchmarks Hopefully, the perf dashboard infrastructure will now be able to handle the amount of data generated by the benchmark. Nevertheless, we throw away all Numeric statistics (standard deviation, sum, count, max, min and percentiles) except for the average using the trick from https://codereview.chromium.org/2005233002/. This should reduce the amount of data pushed to the dashboard approximately 6 times. BUG=589726,610962,catapult:#2340 ==========
lgtm This is lgtm to enable on Monday.
On 2016/06/03 21:33:22, sullivan wrote: > lgtm > > This is lgtm to enable on Monday. Thanks! However, I suppose we should first (see https://bugs.chromium.org/p/chromium/issues/detail?id=617117): * delete non-average values from system-health benchmarks (https://bugs.chromium.org/p/chromium/issues/detail?id=617636) * rename old memory-infra values * normalize memory metric value names (https://codereview.chromium.org/2018503002/) Petr
Description was changed from ========== [perf] Re-enable system_health.memory_* benchmarks Hopefully, the perf dashboard infrastructure will now be able to handle the amount of data generated by the benchmark. Nevertheless, we throw away all Numeric statistics (standard deviation, sum, count, max, min and percentiles) except for the average using the trick from https://codereview.chromium.org/2005233002/. This should reduce the amount of data pushed to the dashboard approximately 6 times. BUG=589726,610962,catapult:#2340 ========== to ========== [perf] Re-enable system_health.memory_* benchmarks Hopefully, the perf dashboard infrastructure will now be able to handle the amount of data generated by the benchmark. Nevertheless, we throw away all Numeric statistics (standard deviation, sum, count, max, min and percentiles) except for the average using the trick from https://codereview.chromium.org/2005233002/. This should reduce the amount of data pushed to the dashboard approximately 6 times. BUG=589726,610962,617117,catapult:#2340 ==========
Description was changed from ========== [perf] Re-enable system_health.memory_* benchmarks Hopefully, the perf dashboard infrastructure will now be able to handle the amount of data generated by the benchmark. Nevertheless, we throw away all Numeric statistics (standard deviation, sum, count, max, min and percentiles) except for the average using the trick from https://codereview.chromium.org/2005233002/. This should reduce the amount of data pushed to the dashboard approximately 6 times. BUG=589726,610962,617117,catapult:#2340 ========== to ========== [perf] Re-enable system_health.memory_* benchmarks Hopefully, the perf dashboard infrastructure will now be able to handle the amount of data generated by the benchmark. Nevertheless, we throw away all Numeric statistics (standard deviation, sum, count, max, min and percentiles) except for the average using the trick from https://codereview.chromium.org/2005233002/. This should reduce the amount of data pushed to the dashboard approximately 6 times. BUG=589726,610962,617117,catapult:#2340 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ==========
The CQ bit was checked by petrcermak@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sullivan@chromium.org Link to the patchset: https://codereview.chromium.org/2012743002/#ps20001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012743002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by petrcermak@chromium.org
The CQ bit was unchecked by petrcermak@chromium.org
The CQ bit was checked by petrcermak@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012743002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_retina_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL) winx64_10_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
On 2016/06/07 18:47:33, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > mac_retina_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL) > winx64_10_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL) Should we be concern about the failure of system_health.memory_desktop in https://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf...
On 2016/06/08 04:45:00, nednguyen wrote: > On 2016/06/07 18:47:33, commit-bot: I haz the power wrote: > > Try jobs failed on following builders: > > mac_retina_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL) > > winx64_10_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL) > > Should we be concern about the failure of system_health.memory_desktop in > https://uberchromegw.corp.google.com/i/tryserver.chromium.perf/builders/mac_r... The problem seems to be that Chrome displays an "Adobe Flash Player was blocked because it is out of date." message and Flipkart subsequently doesn't load: https://console.developers.google.com/m/cloudstorage/b/chrome-telemetry-outpu... Furthermore, from that point onwards, Chrome is stuck on the Flipkart URL and all subsequent stories fail as well (the screenshot stays the same). I'll try to commit the benchmarks once more. If the issue persists (or the patch goes through and then starts failing on the bots), then I'll file a bug about it.
The CQ bit was checked by petrcermak@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012743002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: winx64_10_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by petrcermak@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sullivan@chromium.org Link to the patchset: https://codereview.chromium.org/2012743002/#ps40001 (title: "Remove Flipkart from the storyset")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012743002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_s5_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL) winx64_10_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by petrcermak@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012743002/40001
Description was changed from ========== [perf] Re-enable system_health.memory_* benchmarks Hopefully, the perf dashboard infrastructure will now be able to handle the amount of data generated by the benchmark. Nevertheless, we throw away all Numeric statistics (standard deviation, sum, count, max, min and percentiles) except for the average using the trick from https://codereview.chromium.org/2005233002/. This should reduce the amount of data pushed to the dashboard approximately 6 times. BUG=589726,610962,617117,catapult:#2340 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== [perf] Re-enable system_health.memory_* benchmarks Hopefully, the perf dashboard infrastructure will now be able to handle the amount of data generated by the benchmark. Nevertheless, we throw away all Numeric statistics (standard deviation, sum, count, max, min and percentiles) except for the average using the trick from https://codereview.chromium.org/2005233002/. This should reduce the amount of data pushed to the dashboard approximately 6 times. BUG=589726,610962,617117,catapult:#2340 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ==========
The CQ bit was unchecked by petrcermak@chromium.org
The CQ bit was checked by petrcermak@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012743002/40001
Message was sent while issue was closed.
Description was changed from ========== [perf] Re-enable system_health.memory_* benchmarks Hopefully, the perf dashboard infrastructure will now be able to handle the amount of data generated by the benchmark. Nevertheless, we throw away all Numeric statistics (standard deviation, sum, count, max, min and percentiles) except for the average using the trick from https://codereview.chromium.org/2005233002/. This should reduce the amount of data pushed to the dashboard approximately 6 times. BUG=589726,610962,617117,catapult:#2340 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== [perf] Re-enable system_health.memory_* benchmarks Hopefully, the perf dashboard infrastructure will now be able to handle the amount of data generated by the benchmark. Nevertheless, we throw away all Numeric statistics (standard deviation, sum, count, max, min and percentiles) except for the average using the trick from https://codereview.chromium.org/2005233002/. This should reduce the amount of data pushed to the dashboard approximately 6 times. BUG=589726,610962,617117,catapult:#2340 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [perf] Re-enable system_health.memory_* benchmarks Hopefully, the perf dashboard infrastructure will now be able to handle the amount of data generated by the benchmark. Nevertheless, we throw away all Numeric statistics (standard deviation, sum, count, max, min and percentiles) except for the average using the trick from https://codereview.chromium.org/2005233002/. This should reduce the amount of data pushed to the dashboard approximately 6 times. BUG=589726,610962,617117,catapult:#2340 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== [perf] Re-enable system_health.memory_* benchmarks Hopefully, the perf dashboard infrastructure will now be able to handle the amount of data generated by the benchmark. Nevertheless, we throw away all Numeric statistics (standard deviation, sum, count, max, min and percentiles) except for the average using the trick from https://codereview.chromium.org/2005233002/. This should reduce the amount of data pushed to the dashboard approximately 6 times. BUG=589726,610962,617117,catapult:#2340 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq Committed: https://crrev.com/55b6d5131d5b10e49fc37bb8cd9143d8a5765143 Cr-Commit-Position: refs/heads/master@{#398621} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/55b6d5131d5b10e49fc37bb8cd9143d8a5765143 Cr-Commit-Position: refs/heads/master@{#398621} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
