Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: components/password_manager/core/browser/password_manager_metrics_util.cc

Issue 2012723002: Add separate UMA histograms for the account chooser with 1/many accounts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager_metrics_util.cc
diff --git a/components/password_manager/core/browser/password_manager_metrics_util.cc b/components/password_manager/core/browser/password_manager_metrics_util.cc
index 8b7320d0261f35d139892060f7fc5ff59928bcd6..80cb5b39d55532eddaaddb9faf5bae6bf61dc8c8 100644
--- a/components/password_manager/core/browser/password_manager_metrics_util.cc
+++ b/components/password_manager/core/browser/password_manager_metrics_util.cc
@@ -88,7 +88,19 @@ void LogAutoSigninPromoUserAction(AutoSigninPromoUserAction action) {
AUTO_SIGNIN_PROMO_ACTION_COUNT);
}
-void LogAccountChooserUserAction(AccountChooserUserAction action) {
+void LogAccountChooserUserActionOneAccount(AccountChooserUserAction action) {
+ UMA_HISTOGRAM_ENUMERATION("PasswordManager.AccountChooserDialogOneAccount",
+ action, ACCOUNT_CHOOSER_ACTION_COUNT);
+ // TODO(vasilii): deprecate the histogram when the new ones hit the Stable.
+ UMA_HISTOGRAM_ENUMERATION("PasswordManager.AccountChooserDialog", action,
+ ACCOUNT_CHOOSER_ACTION_COUNT);
+}
+
+void LogAccountChooserUserActionManyAccounts(AccountChooserUserAction action) {
+ UMA_HISTOGRAM_ENUMERATION(
+ "PasswordManager.AccountChooserDialogMultipleAccounts", action,
+ ACCOUNT_CHOOSER_ACTION_COUNT);
+ // TODO(vasilii): deprecate the histogram when the new ones hit the Stable.
UMA_HISTOGRAM_ENUMERATION("PasswordManager.AccountChooserDialog", action,
ACCOUNT_CHOOSER_ACTION_COUNT);
}
« no previous file with comments | « components/password_manager/core/browser/password_manager_metrics_util.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698