Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 20127002: Allow efficient WebURL -> GURL conversions (Closed)

Created:
7 years, 5 months ago by abarth-chromium
Modified:
7 years, 5 months ago
Reviewers:
Jeffrey Yasskin, brettw
CC:
chromium-reviews, Jeffrey Yasskin
Visibility:
Public.

Description

Allow efficient WebURL -> GURL conversions This CL adds a constructor to GURL that takes a std::string instead of a char* and a length. This constructor allows Blink to produce a temporary std::string containing the URL's spec that we can move directly into the GURL, avoiding a copy. Once I update Blink, this constructor will help us avoid spending 5% of our total time rendering http://sina.com.cn on KURL -> GURL conversions. R=brettw BUG=261412 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213885

Patch Set 1 #

Patch Set 2 : Fix debug compile #

Patch Set 3 : Elaborate comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -2 lines) Patch
M url/gurl.h View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M url/gurl.cc View 1 2 chunks +15 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
abarth-chromium
7 years, 5 months ago (2013-07-24 20:39:39 UTC) #1
Jeffrey Yasskin
lgtm. Oh there's the GURL constructor I was missing in WebURL.
7 years, 5 months ago (2013-07-24 21:36:21 UTC) #2
abarth-chromium
Sorry, I should cross-link the CLs. The Blink side is in https://codereview.chromium.org/20135002/.
7 years, 5 months ago (2013-07-24 21:56:47 UTC) #3
abarth-chromium
@brettw: I believe I need your approval to land this GURL change. Thanks!
7 years, 5 months ago (2013-07-24 22:18:38 UTC) #4
brettw
LGTM if you can add a bit more clarity about swapping to the header (otherwise ...
7 years, 5 months ago (2013-07-25 19:34:46 UTC) #5
abarth-chromium
Thanks and done.
7 years, 5 months ago (2013-07-25 19:40:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/20127002/17001
7 years, 5 months ago (2013-07-25 20:57:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/20127002/17001
7 years, 5 months ago (2013-07-26 02:22:51 UTC) #8
commit-bot: I haz the power
7 years, 5 months ago (2013-07-26 13:30:11 UTC) #9
Message was sent while issue was closed.
Change committed as 213885

Powered by Google App Engine
This is Rietveld 408576698