Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2012653004: content_shell: Fix a regression for paths starting with /media/. (Closed)

Created:
4 years, 7 months ago by tkent
Modified:
4 years, 7 months ago
Reviewers:
kinuko
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, jsbell, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo, Rick Byers
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content_shell: Fix a regression for paths starting with /media/. crrev.com/395025 caused a regression that layout tests in /media are not runnable. - Do not rewrite a request URL if it's the first request after Reset(). - Do not rewrite a request URL if it contains "/LayoutTests/". BUG=613408, 614778 Committed: https://crrev.com/00340348688b60b044587900939330cd4ea1e989 Cr-Commit-Position: refs/heads/master@{#396146}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M components/test_runner/test_runner.h View 2 chunks +5 lines, -0 lines 0 comments Download
M components/test_runner/test_runner.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M components/test_runner/web_frame_test_client.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
tkent
kinuko-san, would you review this please?
4 years, 7 months ago (2016-05-26 04:50:23 UTC) #3
kinuko
lgtm
4 years, 7 months ago (2016-05-26 08:07:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012653004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2012653004/1
4 years, 7 months ago (2016-05-26 08:15:13 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-26 08:18:55 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 08:20:22 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/00340348688b60b044587900939330cd4ea1e989
Cr-Commit-Position: refs/heads/master@{#396146}

Powered by Google App Engine
This is Rietveld 408576698