Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2012623002: Don't display chrome-extension URLs for subframes in the TaskManager (Closed)

Created:
4 years, 7 months ago by ncarter (slow)
Modified:
4 years, 7 months ago
Reviewers:
afakhry, Charlie Reis
CC:
chromium-reviews, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@activate_extension
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't display chrome-extension URLs for subframes in the TaskManager Show the extension name instead. BUG=614556 Committed: https://crrev.com/c916a92af8352ef54d2364ade8428bb9ee393e5f Cr-Commit-Position: refs/heads/master@{#396040}

Patch Set 1 #

Patch Set 2 : Partial revert of previous PS #

Patch Set 3 : Subframe. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M chrome/browser/task_management/providers/web_contents/subframe_task.cc View 1 2 2 chunks +22 lines, -3 lines 0 comments Download

Depends on Patchset:

Issue 2006423002 Patch 20001

Messages

Total messages: 11 (4 generated)
ncarter (slow)
4 years, 7 months ago (2016-05-25 22:02:00 UTC) #2
Charlie Reis
Great! LGTM.
4 years, 7 months ago (2016-05-25 22:07:49 UTC) #3
ncarter (slow)
+ahmed as OWNER
4 years, 7 months ago (2016-05-25 22:11:29 UTC) #5
afakhry
lgtm
4 years, 7 months ago (2016-05-25 23:14:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012623002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2012623002/40001
4 years, 7 months ago (2016-05-25 23:16:14 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-25 23:40:14 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 23:41:44 UTC) #11
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/c916a92af8352ef54d2364ade8428bb9ee393e5f
Cr-Commit-Position: refs/heads/master@{#396040}

Powered by Google App Engine
This is Rietveld 408576698