Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2012613002: Enforce/require MOJO_HANDLE_RIGHT_TRANSFER in sending handles via MojoWriteMessage(). (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Enforce/require MOJO_HANDLE_RIGHT_TRANSFER in sending handles via MojoWriteMessage(). R=azani@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/862d13b6f591fb83034e80ed5a8c59fb9d0b7b56

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -3 lines) Patch
M mojo/edk/system/core_unittest.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M mojo/edk/system/handle_table.h View 1 chunk +3 lines, -2 lines 0 comments Download
M mojo/edk/system/handle_table.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/edk/system/handle_table_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/public/c/system/message_pipe.h View 2 chunks +11 lines, -1 line 1 comment Download
M mojo/public/c/system/tests/core_unittest.cc View 1 chunk +30 lines, -0 lines 0 comments Download
M mojo/public/platform/native/system_impl_private_unittest.cc View 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
viettrungluu
4 years, 7 months ago (2016-05-24 23:56:14 UTC) #1
azani
lgtm but for a comment nit https://codereview.chromium.org/2012613002/diff/1/mojo/public/c/system/message_pipe.h File mojo/public/c/system/message_pipe.h (right): https://codereview.chromium.org/2012613002/diff/1/mojo/public/c/system/message_pipe.h#newcode117 mojo/public/c/system/message_pipe.h:117: // Note: |MOJO_RESULT_BUSY| ...
4 years, 7 months ago (2016-05-25 03:23:53 UTC) #2
viettrungluu
On 2016/05/25 03:23:53, azani wrote: > lgtm but for a comment nit > > https://codereview.chromium.org/2012613002/diff/1/mojo/public/c/system/message_pipe.h ...
4 years, 7 months ago (2016-05-25 16:29:06 UTC) #3
viettrungluu
4 years, 7 months ago (2016-05-25 16:32:50 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
862d13b6f591fb83034e80ed5a8c59fb9d0b7b56 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698