Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2012593002: [Media Router WebUI] Fix search focus handlers when search is enabled (Closed)

Created:
4 years, 7 months ago by btolsch
Modified:
4 years, 7 months ago
Reviewers:
apacible
CC:
chromium-reviews, media-router+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router WebUI] Fix search focus handlers when search is enabled This change corrects the point of setting the search focus handlers to be after search first becomes enabled. Previously it was set in ready(), but since disabling search by default, the handlers weren't correctly updated. BUG=592723 R=apacible@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/e5e7577ef96ee5fa24c8952e649312dc5427aa42 Cr-Commit-Position: refs/heads/master@{#395774}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -10 lines) Patch
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js View 4 chunks +7 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
btolsch
I tried writing a test for this case, but either window.blur() isn't really honored in ...
4 years, 7 months ago (2016-05-24 22:31:47 UTC) #2
apacible
lgtm
4 years, 7 months ago (2016-05-25 00:26:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2012593002/1
4 years, 7 months ago (2016-05-25 00:28:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 01:55:28 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 01:57:22 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e5e7577ef96ee5fa24c8952e649312dc5427aa42
Cr-Commit-Position: refs/heads/master@{#395774}

Powered by Google App Engine
This is Rietveld 408576698