Use ContentViewCore's container view to keep screen on

ui/android/java/src/org/chromium/ui/ViewAndroid.java

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.ui;
 
+import android.view.View;
+
 import org.chromium.base.JNINamespace;
 import org.chromium.ui.ViewAndroidDelegate;
 import org.chromium.ui.WindowAndroid;
 
 /**
  * From the Chromium architecture point of view, ViewAndroid and its native counterpart
  * serve purpose of representing Android view where Chrome expects to have a cross platform
  * handle to the system view type. As Views are Java object on Android, this ViewAndroid
  * and its native counterpart provide the expected abstractions on the C++ side and allow
  * it to be flexibly glued to an actual Android Java View at runtime.
  *
  * It should only be used where access to Android Views is needed from the C++ code.
  */
 @JNINamespace("ui")
 public class ViewAndroid {
     // Native pointer to the c++ ViewAndroid object.
     private int mNativeViewAndroid = 0;
     private final ViewAndroidDelegate mViewAndroidDelegate;
     private final WindowAndroid mWindowAndroid;
+    private int mKeepScreenOnCount;
+    private View mKeepScreenOnView;
 
     /**
      * Constructs a View object.
      */
     public ViewAndroid(WindowAndroid nativeWindow, ViewAndroidDelegate viewAndroidDelegate) {
         mWindowAndroid = nativeWindow;
         mViewAndroidDelegate = viewAndroidDelegate;
         mNativeViewAndroid = nativeInit(mWindowAndroid.getNativePointer());
     }
 
@@ skipping 12 matching lines @@
     }
 
     /**
      * Returns a pointer to the c++ AndroidWindow object.
      * @return A pointer to the c++ AndroidWindow.
      */
     public int getNativePointer() {
         return mNativeViewAndroid;
     }
 
+    /**
+     * Set whether to keep screen on when this view is in foreground.
+     * @param keepScreenOn true if the screen needs to keep on.
+     */
+    public void setKeepScreenOn(boolean keepScreenOn) {

[newt (away), 2013/08/09 20:57:21]

I think it should be more clear that this method is *not* a traditional setter.
Perhaps it could be split into two functions named
"incrementKeepScreenOnCount()" and "decrementKeepScreenOnCount()". The javadoc
should also be clear about this.

[michaelbai, 2013/08/09 23:06:50]

It was named by Android's convention, but yes, the increment/decrement are
better. 


On 2013/08/09 20:57:21, newt wrote:

+        if (keepScreenOn) {
+            mKeepScreenOnCount++;
+            if (mKeepScreenOnCount == 1) {
+                mKeepScreenOnView = mViewAndroidDelegate.acquireAnchorView();
+                mKeepScreenOnView.setKeepScreenOn(true);
+            }
+        } else {
+            assert mKeepScreenOnCount > 0;
+            mKeepScreenOnCount--;
+            if (mKeepScreenOnCount == 0) {
+                mViewAndroidDelegate.releaseAnchorView(mKeepScreenOnView);
+                mKeepScreenOnView = null;
+            }
+        }
+    }
+
     private native int nativeInit(int windowPtr);
     private native void nativeDestroy(int nativeViewAndroid);
 }