Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Issue 2012413004: hacking on a single-benchmark tool (Closed)

Created:
4 years, 6 months ago by mtklein_C
Modified:
4 years, 5 months ago
Reviewers:
herb_g, mtklein
CC:
Brian Osman, hal.canary, msarett, reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : print every sample #

Patch Set 3 : some hacking #

Patch Set 4 : a bit better #

Patch Set 5 : hacking on reverse #

Patch Set 6 : more #

Patch Set 7 : share the mul #

Patch Set 8 : add sqrt(x) + x version #

Patch Set 9 : table #

Patch Set 10 : another two cases of s -> l #

Patch Set 11 : split out benches #

Patch Set 12 : split out bench code, run multiple benchmarks #

Patch Set 13 : enforce bench_ convention --> pithier display #

Patch Set 14 : whoops #

Patch Set 15 : display ascending #

Patch Set 16 : display relative by default, absolute if requested or single benchmark #

Patch Set 17 : clearer there #

Patch Set 18 : simpler #

Patch Set 19 : simpler math #

Patch Set 20 : move to monobench/ #

Patch Set 21 : add a gyp #

Patch Set 22 : some real benching #

Patch Set 23 : be normal #

Patch Set 24 : automatic #

Patch Set 25 : tweaks #

Patch Set 26 : more tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -0 lines) Patch
M gyp/everything.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +1 line, -0 lines 0 comments Download
M gyp/tools.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 1 chunk +32 lines, -0 lines 0 comments Download
A tools/monobench.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 1 chunk +114 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (15 generated)
mtklein_C
4 years, 6 months ago (2016-05-27 18:21:23 UTC) #3
mtklein
I've refactored pretty significantly. Might want another read through / patch if you're using this.
4 years, 6 months ago (2016-06-08 15:23:31 UTC) #5
herb_g
This is looking super interesting.
4 years, 6 months ago (2016-06-08 15:40:28 UTC) #6
mtklein_C
+Brian, what I was showing you earlier.
4 years, 6 months ago (2016-06-08 17:48:41 UTC) #8
mtklein_C
+Matt. This has the examples of each s->l and l->s.
4 years, 6 months ago (2016-06-09 13:52:26 UTC) #10
mtklein_C
+Hal, to inspire thoughts about how to structure benchmarks.
4 years, 6 months ago (2016-06-09 14:08:35 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012413004/490001
4 years, 6 months ago (2016-06-14 13:12:22 UTC) #14
mtklein_C
I've hooked this into all the existing non-rendering benchmarks. PTAL? Example usage: ./gyp_skia ninja -C ...
4 years, 6 months ago (2016-06-14 13:23:11 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-14 13:26:14 UTC) #18
mtklein_C
ping
4 years, 5 months ago (2016-07-11 17:52:20 UTC) #19
herb_g
lgtm
4 years, 5 months ago (2016-07-11 18:04:15 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2012413004/490001
4 years, 5 months ago (2016-07-11 18:26:38 UTC) #26
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 18:27:34 UTC) #28
Message was sent while issue was closed.
Committed patchset #26 (id:490001) as
https://skia.googlesource.com/skia/+/7e602c2c6cb2fbeb70a3978e2148844b673a8a4c

Powered by Google App Engine
This is Rietveld 408576698