Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2012413002: Revert of GLContextGLX: try all GL versions from the highest. (Closed)

Created:
4 years, 7 months ago by Corentin Wallez
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of GLContextGLX: try all GL versions from the highest. (patchset #4 id:60001 of https://codereview.chromium.org/1999543003/ ) Reason for revert: Causes a lot of failures on the GPU FYI waterfall. Original issue's description: > GLContextGLX: try all GL versions from the highest. > > Also try all ES versions from the highest. This change will allow > Chrome to create a GL context higher than 3.0 on Mesa and will in turn > allow WebGL2 to run on Intel Linux when using the native GL driver. > > This patch is a direct port of the logic in ANGLE's DisplayGLX > > BUG=598902 > > Committed: https://crrev.com/3464004765597c914d8499ee9792cf81e106a4ae > Cr-Commit-Position: refs/heads/master@{#396243} TBR=qiankun.miao@intel.com,zmo@chromium.org,kbr@chromium.org,piman@chromium.org,cwallez@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=598902 Committed: https://crrev.com/59d51f9a4cea0fd3d0c27eaf069442b9f556ea9a Cr-Commit-Position: refs/heads/master@{#396299}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -149 lines) Patch
M ui/gl/gl_context_glx.cc View 2 chunks +13 lines, -131 lines 0 comments Download
M ui/gl/gl_surface_glx.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/gl/gl_surface_glx.cc View 3 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Corentin Wallez
Created Revert of GLContextGLX: try all GL versions from the highest.
4 years, 7 months ago (2016-05-26 22:17:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2012413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2012413002/1
4 years, 7 months ago (2016-05-26 22:18:22 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-26 22:19:10 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 22:20:55 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/59d51f9a4cea0fd3d0c27eaf069442b9f556ea9a
Cr-Commit-Position: refs/heads/master@{#396299}

Powered by Google App Engine
This is Rietveld 408576698